[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-15 Thread Colin Watson
Moved to main. ** Changed in: cups-pk-helper (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To manage notifi

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-11 Thread Jamie Strandboge
Based on Till's feedback and looking at 0.2.4-0ubuntu4, this meets the conditional ACK. ** Changed in: cups-pk-helper (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.la

Re: [Bug 808829] Re: [MIR] cups-pk-helper

2012-12-10 Thread Martin Pitt
Till Kamppeter [2012-12-10 19:11 -]: > Added the hardening to the cups-pk-helper package and checked whether > system-config-printer still works correctly with it which is the case. > Made build system more verbose to check whether hardening options got > really applied on compiling and linking

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-10 Thread Till Kamppeter
Added the hardening to the cups-pk-helper package and checked whether system-config-printer still works correctly with it which is the case. Made build system more verbose to check whether hardening options got really applied on compiling and linking, which is also the case. Checked also the test

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-09 Thread Martin Pitt
** Changed in: cups-pk-helper (Ubuntu) Assignee: Martin Pitt (pitti) => Till Kamppeter (till-kamppeter) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To mana

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-07 Thread Jamie Strandboge
Security review: With a shallow code audit, the code seems ok and is quite small. It (obviously) ships a dbus system service. The recent fixes for the CVE look ok. Upstream reported the issue responsibly, provided patches and was receptive to feedback on the patches. The package is a root runnin

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-07 Thread Jamie Strandboge
@Till, fyi, this was only uploaded a week ago to quantal-proposed. We also need testers for oneiric and precise. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-07 Thread Jamie Strandboge
Thanks! ** Changed in: cups-pk-helper (Ubuntu) Status: Confirmed => In Progress ** Changed in: cups-pk-helper (Ubuntu) Assignee: Ubuntu Security Team (ubuntu-security) => Jamie Strandboge (jdstrand) -- You received this bug notification because you are a member of Ubuntu Bugs, whic

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-07 Thread Till Kamppeter
seb128, I am running said version of cups-pk-helper for some weeks under Quantal and it did not cause any regressions for me. Marked the CVE bug verified. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-07 Thread Sebastien Bacher
@Jamie: desktop will do the verification, it's friday night though so maybe not before monday... (Subscribing Till) Hey Till, is there any chance you could help testing that cups-pk-helper security update? -- You received this bug notification because you are a member of Ubuntu Bugs, which is s

[Bug 808829] Re: [MIR] cups-pk-helper

2012-12-07 Thread Jamie Strandboge
FYI, a fix for CVE-2012-4510 (bug #1083416) is available in proposed, but no one has verified it yet. Since part of consideration for main is how well is package has been maintained in Ubuntu to date, can someone test those? -- You received this bug notification because you are a member of Ubuntu

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-26 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/gnome-control-center -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To manage notifications about this bug go to: https://bugs.launchpa

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-26 Thread Jamie Strandboge
A member of the security team will review it and report back. ** Changed in: cups-pk-helper (Ubuntu) Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.la

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-26 Thread Sebastien Bacher
Ok, I'm a bit unsure where we stand... It was not very well looked at since it was in universe, once promoted the desktop team will look at it and make sure fixes land in a reasonable timeframe. The codebase is small and the package is shipped in almost all the other distros and maintained upstre

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-26 Thread Jamie Strandboge
One of the criteria for main inclusion is how well it has been maintained in the past in Ubuntu. Another is if there is a security history, then it needs a security review. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.l

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-26 Thread Sebastien Bacher
Thanks Jamie, the issue is fixed in raring it seems ... do you consider the fact that it's not in older serie as an issue for the MIR request? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Titl

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-26 Thread Jamie Strandboge
This has a CVE history: CVE-2012-4510. See http://www.debian.org/security/2012/dsa-2562 (it is still unfixed in Ubuntu 12.10 and lower, so it hasn't gotten community attention in Ubuntu yet). ** CVE added: http://www.cve.mitre.org/cgi- bin/cvename.cgi?name=2012-4510 -- You received this bug noti

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-26 Thread Sebastien Bacher
Didier said that the MIR is approved and that we can add the recommends to g-c-c, we just need to ping him for promotion after upload -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-25 Thread Launchpad Bug Tracker
** Branch linked: lp:~ubuntu-desktop/gnome-control-center/ubuntu -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To manage notifications about this bug go to: https

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-25 Thread Jeremy Bicha
The port to gdbus happened for 0.2.0. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To manage notifications about this bug go to: https://bugs.launchpad.net/ubunt

[Bug 808829] Re: [MIR] cups-pk-helper

2012-11-25 Thread Jeremy Bicha
We're now shipping the GNOME System Settings>Printers panel in Raring. Without cups-pk-helper, you can't add a printer (bug 1082765). ** Changed in: cups-pk-helper (Ubuntu) Status: Won't Fix => Confirmed ** Changed in: cups-pk-helper (Ubuntu) Assignee: Didier Roche (didrocks) => (unas

[Bug 808829] Re: [MIR] cups-pk-helper

2011-08-15 Thread Martin Pitt
For oneiric we will use system-config-printer instead of the upstream g-c-c thing, so let's put this on hold until we need it again. ** Changed in: cups-pk-helper (Ubuntu) Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 808829] Re: [MIR] cups-pk-helper

2011-08-02 Thread Didier Roche
(setting as incomplete for now) ** Changed in: cups-pk-helper (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To manage n

[Bug 808829] Re: [MIR] cups-pk-helper

2011-07-18 Thread Didier Roche
As Martin said, straightforward packaging, small code already in use in other distros, usage of different libs seems correct. Seems there is no direct plan to port to gdbus (and 0.1.3 is out as well). Nothing risky from what I see in the code, so +1 from my side. Need to fix the old fsf address w

[Bug 808829] Re: [MIR] cups-pk-helper

2011-07-12 Thread Michael Terry
** Changed in: cups-pk-helper (Ubuntu) Assignee: (unassigned) => Didier Roche (didrocks) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/808829 Title: [MIR] cups-pk-helper To manage notification

[Bug 808829] Re: [MIR] cups-pk-helper

2011-07-11 Thread Martin Pitt
Things that caught my eye during review: - Uses dbus-glib, should be ported to gdbus at some point. - cups-pk-helper-mechanism.c is by and large boilerplate code and looks correct to me. The polkit result is properly checked, and there are no complicated memory operations. - cups.c is rather l