[Bug 717879] Re: germinate should not examine all components in PPAs

2011-04-05 Thread Launchpad Bug Tracker
This bug was fixed in the package germinate - 1.25 --- germinate (1.25) unstable; urgency=low * Only raise an exception from open_tag_files if an appropriate file is not found on any mirror (thanks, Tom Gall, Steve Langasek, and Barry Warsaw; LP: #717879). -- Colin Watson

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-04-05 Thread Colin Watson
** Changed in: germinate (Ubuntu) Status: Triaged => Fix Committed ** Changed in: germinate (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/717879 Tit

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-04-05 Thread Colin Watson
I think it's clearer to move tag_files.append(tag_file) into the inner loop anyway; tag_file_open always either raises an exception or returns non-None, and this makes that clear. I'll deal with this and Barry's other nits. Thanks! -- You received this bug notification because you are a member

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-03-31 Thread Luke Yelavich
** Changed in: germinate (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/717879 Title: germinate should not examine all components in PPAs -- ubuntu-bugs maili

Re: [Bug 717879] Re: germinate should not examine all components in PPAs

2011-03-31 Thread Steve Langasek
On Thu, Mar 31, 2011 at 08:42:41PM -, Barry Warsaw wrote: > Why do you add the empty string to the suffix list in the for loop? I > see that the original code unconditionally adds the unsuffixed value of > open_tag_file() if both .bz2 and .gz fail. Is that the real source of > the bug (iow, op

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-03-31 Thread Barry Warsaw
Hi Tom, thanks for the patch. I'll have to let Colin make the final determination, both because he knows the code much better than I do and because he has upload rights where I do not. I do have some questions after looking at your patch from 2011-02-15. First: since you have a branch that conta

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-16 Thread Tom Gall
This patch has been running well over the past couple of days. I haven't run into any issues for the variety of linaro-seed work that I do. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/717879 Title:

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-15 Thread Brian Murray
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/717879 Title: germinate should not examine all components in PPAs -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https:

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-15 Thread Tom Gall
** Patch added: "proposed fix" https://bugs.launchpad.net/ubuntu/+source/germinate/+bug/717879/+attachment/1851678/+files/fix-717879.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/717879 Tit

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-15 Thread Tom Gall
With the genius of Steve Langasek, we've (well he) authored a proposed fix. I'm still testing it at the moment, but none the less I'll link the code here to the bug. You might find it acceptable. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-15 Thread Launchpad Bug Tracker
** Branch linked: lp:~tom-gall/germinate/fix-717879 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/717879 Title: germinate should not examine all components in PPAs -- ubuntu-bugs mailing list ubun

Re: [Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-15 Thread Colin Watson
Um, you're overreacting a bit there - I'll fix this bug. I just meant to say that special-casing PPAs is not the correct fix, and describe my thinking on the correct solution. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bu

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-13 Thread Tom Gall
If by awkward you mean to say that PPAs can no longer be used with germinate when the seed uses more than just the main component. For linaro, the impact that I see is we'll have to either fork germinate (yuck!) or setup our own archive for content that is now found in PPAs. It would seem the use

[Bug 717879] Re: germinate should not examine all components in PPAs

2011-02-12 Thread Colin Watson
I don't intend to add special cases for any archive, PPAs or not. However, clearly this is awkward since you want universe from the first archive in the list but want to disregard the fact that it doesn't exist in the second, and there's no way to configure that explicitly in germinate (it would pr