[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-03-10 Thread Martin Pitt
As this affects more cases (like humanity-icon-theme), I'll add the extra rsvg before-after comparison to dh_scour. It'll take longer to build, but is the safe option. ** Changed in: scour (Ubuntu) Status: New => Triaged ** Changed in: scour (Ubuntu) Assignee: (unassigned) => Martin P

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-03-05 Thread Tobias Wolf
Disk Utility a.k.a. palimpsest is also affected. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: Scour corrupts deja-dup.svg -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com ht

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-02-07 Thread Louis Simard
Your proposed fix doesn't do anything for the problem described in this bug report. But since it does fix an error in the code, I'll apply it anyway. Thanks :) This bug report will remain open because its root cause has not been addressed yet. -- You received this bug notification because you ar

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-02-07 Thread Jan Thor
The problem with removeDuplicateGradients is the comparison of two gradient stops, which doesn’t look at the style attribute. So for scour, two stops might look the same, although they specify completely different colors (or opacities) within their style attribute. Since Inkscape stores stop colors

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-31 Thread Paul Sladen
Back on-topic; we could probably be a bit more pragmatic is choosing which SVG to ship. Rendering both before.svg and after.svg with 'rsvg' (or other rasteriser of choice) and then comparing the resulting bitmaps should be enough; if they're the same, result, and if not, revert back and ship the

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-31 Thread Paul Sladen
towolf: Off-topic, but what is the font being used in the browser in that evolution screenshot? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: Scour corrupts deja-dup.svg -- ubuntu-bu

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-31 Thread Tobias Wolf
the same with the Evolution icon. This scouring process seems to be quite lossy. ** Attachment added: "evolution.png" https://bugs.launchpad.net/ubuntu/+source/scour/+bug/702423/+attachment/1819444/+files/evolution.png -- You received this bug notification because you are a member of Ubuntu

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-30 Thread Tobias Wolf
Same with Totem’s shipped SVG logo that is used as a big placeholder upon starting totem. This is how it should look: http://git.gnome.org/browse/totem/plain/data/icons/scalable/totem.svg Attached is how it looks now ** Attachment added: "totem.svg" https://bugs.launchpad.net/ubuntu/+source/

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-14 Thread Louis Simard
I isolated it to removeDuplicateGradients or something it calls. In Scour revision 195, elements referencing a duplicate gradient are updated for renaming only in xlink:href and XML fill=, stroke= etc. attributes, so anything in style= doesn't get updated. I confirmed that it's removeDuplicateGra

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-14 Thread Paul Sladen
Louis: thank you for working through it so late, even if the final cause has not yet shown revealed itself! It is appreciated. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: Scour corr

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Louis Simard
Apologies for the hasty diagnostic; a reference is actually found correctly by calls to findReferencingProperty... That will teach me to debug while tired. But I can see that the bug occurs on the latest Scour with the --disable-style-to-xml option, so marking Confirmed. ** Changed in: scour

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Louis Simard
findReferencedElements has this in its code, at line 451, which depends on the "referencing properties" being XML attributes: # now get all style properties and the fill, stroke, filter attributes styles = node.getAttribute('style').split(';') for attr in referencingProps: st

Re: [Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread codedread
Ah, sorry missed that you were using that flag. Might be able to look at it at some point in the future, but I think someone else implemented that flag. Jeff On Thu, Jan 13, 2011 at 4:29 PM, Michael Terry wrote: > The latest version of scour is only one commit ahead of what I (Ubuntu > natty) w

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Michael Terry
The latest version of scour is only one commit ahead of what I (Ubuntu natty) was using. But I tried it, no change. However, if I don't use --disable-style-to-xml, it works. So it seems like an issue with that flag. -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread codedread
Just tried it on the latest version of Scour and it seems to be ok. Can you please download the trunk version and try it? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: Scour corrupts

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread codedread
Definitely looks like a bug. linearGradient2513 is being removed by scour... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: Scour corrupts deja-dup.svg -- ubuntu-bugs mailing list ub

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Paul Sladen
binary: $ dpkg -S deja-dup.svg app-install-data: /usr/share/app-install/icons/deja-dup.svg source: $ apt-get source app-install-data-ubuntu -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Michael Terry
Ooh, interesting. When viewed in Firefox, scour seems to have made the arrows black. On my system (via librsvg?), the arrows have been made partly-invisible as I mentioned in the description. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to U

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Martin Pitt
For the record, we run scour with --disable-style-to-xml and no other options (aside from -i and -o). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: Scour corrupts deja-dup.svg -- ubu

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Michael Terry
** Attachment added: "scoured" https://bugs.launchpad.net/ubuntu/+source/scour/+bug/702423/+attachment/1792771/+files/deja-dup.svg ** Also affects: scour Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subsc

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Michael Terry
** Attachment added: "pristine" https://bugs.launchpad.net/ubuntu/+source/scour/+bug/702423/+attachment/1792770/+files/deja-dup.svg -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: S

[Bug 702423] Re: Scour corrupts deja-dup.svg

2011-01-13 Thread Michael Terry
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/702423 Title: Scour corrupts deja-dup.svg -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-b