[Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-09 Thread jonie
Yes, of course, in this sense blank DVD-RW Restricted Overwrite is non-finalized, too. But multi-track aka multi-border DVD is something beyond specs, AFAIK there is always a single track. These statuses reported by the drive are valid, this is rather a dirty (although working) patch, but they c

Re: [Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-09 Thread Martin Pitt
Ah, sorry, I meant "multi-track", not "multi-session". Isn't "append" also used for non-finalized multi-track CDs? -- cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM https://bugs.launchpad.net/bugs/581925 You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-09 Thread jonie
But you're right, just in case someone does multi-border sequential (exotic) we need to distinguish between Restricted Overwrite and Sequential ** Attachment added: "patch" http://launchpadlibrarian.net/53323405/patch -- cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM https://bugs.l

[Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-09 Thread jonie
AFAIK, you can't. "Multisession" is done as extending the file system within the single session. There is only something non-standard like multi border DVD-R. The appendable status for DVD-RW simply means there is no lead-out yet (but the one and only session exists), DVD+RW doesn't care for legacy

Re: [Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-09 Thread Martin Pitt
jonie [2010-08-08 22:58 -]: > + /* fresh dvd-rw in restricted overwite mode is "appendable", change it > to "blank" to satisfy udev */ > + if (cd_media_dvd_rw && (header[2] & 3) == 1) > + cd_media_state = media_status[0]; Can you please explain this a little further? This

[Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-08 Thread jonie
One more little addition about -RW (and the last I think): DVD-RW formatted into Sequential mode is seen as "0" (blank) if empty or "2" (complete) if holds any data, needs no intervention here, works just like CD-RW DVD-RW in Restricted Overwrite mode that's been written to, blanked or not is "2

Re: [Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-08 Thread Martin Pitt
Hello jonie, jonie [2010-08-08 16:37 -]: > - include DVD-RW (in Restricted Overwrite mode it's basically same as > DVD+RW, I finally found one that I could blank) > > - if ((cd_media_dvd_plus_rw || cd_media_dvd_plus_rw_dl || > cd_media_dvd_ram) && (header[2] & 3) > 1) { > + if ((

[Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-08 Thread jonie
You're welcome! Two minor omissions crept in: - include DVD-RW (in Restricted Overwrite mode it's basically same as DVD+RW, I finally found one that I could blank) - if ((cd_media_dvd_plus_rw || cd_media_dvd_plus_rw_dl || cd_media_dvd_ram) && (header[2] & 3) > 1) { + if ((cd_media_d

[Bug 581925] Re: cdrom_id: Does not recognize reblanked DVD+RW and DVD-RAM

2010-08-08 Thread Martin Pitt
I confirm that this works great here. Committed upstream, with some minor code cleanup: http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=1ef6c9e9f0f405d1fed403c13c57a233a484bed7 Thanks, jonie! ** Changed in: udev (Ubuntu) Status: In Progress => Fix Committed ** Changed in: