[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread Launchpad Bug Tracker
This bug was fixed in the package dmg2img - 1.6.1-1ubuntu1 --- dmg2img (1.6.1-1ubuntu1) lucid; urgency=low * debian/rules: Add simple patchsys to CDBS packaging * Fix segmentation fault caused by incorrect terminator block handling - backported from upstream 1.6.2 (LP: #54615

[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread TJ
Fixes incorrect handling of terminator blocks that results in segmentation faults. Backported from upstream 1.6.2. ** Attachment added: "Debdiff for Lucid" http://launchpadlibrarian.net/41918098/dmg2img_1.6.1-1ubuntu1.debdiff ** Patch removed: "Do not segfault when TERM block data pointer is N

[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread TJ
I reported this to the upstream project and they have applied a bug-fix and released version 1.6.2 that fixes this. Unfortunately for us the new 1.6.2 source package also includes a template debian/ directory with example files and incomplete entries for the key files like control. Therefore I don

[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread TJ
** Changed in: dmg2img (Ubuntu) Status: New => Triaged ** Changed in: dmg2img (Ubuntu) Importance: Undecided => Medium -- dmg2img crashed with SIGSEGV in convert_char8() https://bugs.launchpad.net/bugs/546154 You received this bug notification because you are a member of Ubuntu Bugs, w

[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread TJ
Right now I'm using the attached patch to work around the issue, although at this point I do not know if this is the correct solution, or if the resulting image is 'good'. ** Patch added: "Do not segfault when TERM block data pointer is NULL" http://launchpadlibrarian.net/41859903/do_not_segfa

[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread TJ
Although the code path shows this, running with -V (extra verbose) mode shows that the failure is when parsing the BT_TERM block: ... [9] 75.00% offset = 360 block_type = 0x7ffe 0x7ffe (in_addr=0 in_size=0 out_addr=673062912 out_size=0) comment +end [10] 83.33% offset = 400 block_type

[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread TJ
The problem is in dmg2img.c, around line 560: if (convert_char8((unsigned char *)parts[1].Data + 24) != 0) Looking at the backtrace, gdb shows that 0x18 is passed to convert_char8(): #0 0x08048d5a in convert_char8 (c=0x18 ) at dmg2img.h:80 0x18 == 24 decimal, the value added to parts[1].Data.

[Bug 546154] Re: dmg2img crashed with SIGSEGV in convert_char8()

2010-03-24 Thread TJ
** Attachment added: "CoreDump.gz" http://launchpadlibrarian.net/41851703/CoreDump.gz ** Attachment added: "Dependencies.txt" http://launchpadlibrarian.net/41851704/Dependencies.txt ** Attachment added: "Disassembly.txt" http://launchpadlibrarian.net/41851705/Disassembly.txt ** Attachm