[Bug 479947] Re: TCPAccountHandler.cpp: bad erase

2010-02-26 Thread Charlie Kravetz
Thank you for helping improve Ubuntu. However, this discussion would be better if done directly with the developers of Abiword. They can be contacted in several ways as explained at http://www.abisource.com/help /en-US/problems/problemshelp.html . Thanks again and please report any bugs you find.

[Bug 479947] Re: TCPAccountHandler.cpp: bad erase

2009-11-10 Thread uwog
Well, this is basic for-loop stuff: the expression "it = next" in the for loop will be executed before the continuation condition it != m_clients.end() will be executed. -- TCPAccountHandler.cpp: bad erase https://bugs.launchpad.net/bugs/479947 You received this bug notification because you are a

[Bug 479947] Re: TCPAccountHandler.cpp: bad erase

2009-11-10 Thread dcb
>the iterator is not used anymore after the erase. What about testing for end of loop ? it != m_clients.end() This test happens after the erase. Maybe I haven't explained the point clearly enough. Please see http://www.cppreference.com/wiki/stl/vector/erase for more details. -- TCPAccountH

[Bug 479947] Re: TCPAccountHandler.cpp: bad erase

2009-11-10 Thread uwog
The code is perfectly fine, since the iterator is not used anymore after the erase. You can see it by looking at the loop condition: for (std::map >::iterator it = m_clients.begin(); it != m_clients.end(); it = next) { next = it;