** Tags added: check-for-breezy
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/322327
Title:
Integrated permissions/ownership diff output for etckeeper/bzr
To manage notifications about this bug go
The new feature flags feature might be useful for this.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/322327
Title:
Integrated permissions/ownership diff output for etckeeper/bzr
To manage notifica
** Changed in: bzr (Ubuntu)
Status: New => Confirmed
** Changed in: bzr (Ubuntu)
Status: Confirmed => Triaged
--
Integrated permissions/ownership diff output for etckeeper/bzr
https://bugs.launchpad.net/bugs/322327
You received this bug notification because you are a member of Ubun
** Changed in: etckeeper (Ubuntu)
Status: Confirmed => Triaged
--
Integrated permissions/ownership diff output for etckeeper/bzr
https://bugs.launchpad.net/bugs/322327
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bug
Don't have time to work on it right now, so if anyone is interested...
** Changed in: bzr
Status: In Progress => Confirmed
** Changed in: bzr
Assignee: Thierry Carrez (ttx) => (unassigned)
--
Integrated permissions/ownership diff output for etckeeper/bzr
https://bugs.launchpad.net/b
** Changed in: bzr
Importance: Undecided => Wishlist
** Changed in: bzr
Status: New => In Progress
** Changed in: bzr
Assignee: (unassigned) => Thierry Carrez (ttx)
--
Integrated permissions/ownership diff output for etckeeper/bzr
https://bugs.launchpad.net/bugs/322327
You receiv
Something like that. It seems to me that you may need two sets of hooks
- core and UI ones. It may even be that all the things you are hooking
are UI level.
--
Integrated permissions/ownership diff output for etckeeper/bzr
https://bugs.launchpad.net/bugs/322327
You received this bug notification
Thanks Robert for your advice.
You are right it makes more sense to change iter_changes in all cases,
since the idea is to cover all cases.
Note that my idea was to use the hook to add files that happen just to
have their metadata changed (so that they show as "changed" for all
purposes), but als
I would make the iter_changes modifier a Tree hook. Should it modify
iter_changes for things other than diff? e.g. status (I assume yes)),
commit? revert?
I'd do Tree.hooks 'iter_changes' as the hook point.
parameter list of old_tree, new_tree, changes, [rest of iter_changes
normal parameters]. Th
** Also affects: bzr
Importance: Undecided
Status: New
--
Integrated permissions/ownership diff output for etckeeper/bzr
https://bugs.launchpad.net/bugs/322327
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mai
I managed to build a PoC integrated diff using two hooks in bzr:
* First one (called showdiff_modifychanges in the patch) allows to
modify the changes iterator just before it's used in diff.py:_show_diff,
so that you can add the files that just have a metadata difference
* Second one (called show
Hmm... hooking at InterTree.iter_changes fails to catch all cases
unfortunately (for example bzr diffing between current state and last
revision uses InterDirStateTree instead). We probably need to hook at a
higher level, like merging entries coming from extra iterators (that our
hook would provide
** Changed in: etckeeper (Ubuntu)
Status: New => Confirmed
--
Integrated permissions/ownership diff output for etckeeper/bzr
https://bugs.launchpad.net/bugs/322327
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs ma
I think we need to hook in two places:
- InterTree.iter_changes (tree.py:928)
We need to yield file_ids that happen to just have a permissions/ownership
change. A hook allowing to arbitrarily yield some entries (given their file_id)
would definitely help.
- DiffTree._show_diff (diff.py:867)
We
14 matches
Mail list logo
