[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-29 Thread Chris MacNaughton
@mruffell is there anything I can do to help ensure this gets into that cycle? can certainly be one more "this patch works for me" but do let me know if there's more I can do to help! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. htt

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-29 Thread Matthew Ruffell
Great, thanks for trying the test kernel. I think the best way forward is to submit TJ's patch, it really is a better solution that backporting the entire mini c runtime or reverting the commit that introduced the problem. I can write a SRU template and submit it tomorrow. We need to try catch t

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-29 Thread Shantur Rathore
@TJ - Thanks for pointing that out. I was indeed using the wrong kernel version. With the test kernel it works perfectly. Does anyone know how to engage someone from Canonical Kernel team to get this merged for Noble? Thanks -- You received this bug notification because you are a member of Ubu

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-27 Thread TJ
@Shantur I also tested with your specific parameter in case it contained something to trigger this but it works fine: (initramfs) uname -a; cat /proc/cmdline Linux (none) 6.8.0-39-generic #39+TEST2069534v20240727b1-Ubuntu SMP PREEMPT_DYNAMIC Sat Jul 27 aarch64 GNU/Linux debug testparam=f081c381e

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-27 Thread TJ
@Shantur I confirm your results trying to boot that kernel image in QEMU and unfortunately there does not appear to be a debug symbols package generated so I cannot debug it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-27 Thread Shantur Rathore
Oh dear, I don't have good news. I installed the kernel on my RockPro64 with the steps mentioned by Matthew, it booted normally without the testparam from the report. I added the testparam in grub testparam=f081c381e7b54edcba27e5f790d47911a4cc3e726d8d256878d3df9175c020e0f081c381e7b54edcba27e5f79

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-27 Thread TJ
I don't use Ubuntu kernels; build my own mainline but work on kernel issues in mainline and Debian. I tested 144..157 length (interestingly although arm64 professes to support 2048 characters the kernel messages are truncated at around 1000 so don't show the entire thing $ qemu-system-aarch64 -mac

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread Matthew Ruffell
Hi TJ, Shantur, Chris, If you wait 3 hours from this message, the kernels will likely be ready. They are building in: https://launchpad.net/~mruffell/+archive/ubuntu/lp2069534-test They are 6.8.0-39-generic + your patch. Both for Noble and Jammy HWE. Test whatever you like. Please note this pa

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread Matthew Ruffell
Hi TJ, Thanks for your fix, this looks much, much more palatable than backporting the entire mini C runtime, or reverting the commit that caused this problem. Now, just as Greg K-H says, 6.8.y is EOL upstream, and is closed to new patches. We can probably pick this up as a SAUCE patch for Ubuntu

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread TJ
@Chris: no idea - someone in the Canonical kernel team needs to deal with it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6.8 fails to boot on arm64 if any param is more than

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread TJ
Upstream stable tree patch submission: https://lore.kernel.org/stable/JsQ4W_o2R1NfPFTCCJjjksPED-8TuWGr796GMNeUMAdCh-2NSB_16x6TXcEecXwIfgzVxHzeB_- PMQnvQuDo0gmYE_lye0rC5KkbkDgkUqM=@proton.me/T/#u -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread Chris MacNaughton
In addition to proposing the fix upstream, what's the timeline for inclusion into Ubuntu's 6.8 kernel / Noble? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6.8 fails to boot on

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread TJ
My hunch about the length of struct aliases was correct; when a parameter that is longer than the *entire* aliases struct element (146 characters) is compared the call to memcmp() is redirected to "include/linux/fortify-string.h" [0] where checks are done to ensure there are no out-of-bounds reads.

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread Shantur Rathore
That's awesome. Thanks for sharing the details. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6.8 fails to boot on arm64 if any param is more than 140 chars To manage notificat

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread TJ
My aim is not to revert a commit but to discover what the actual bug is and get it fixed in upstream stable 6.8 tree. I've isolated it to kernel-only by eliminating both firmware (UEFI) and boot-loader (GRUB) from the equation with: qemu-system-aarch64 -machine virt,gic-version=3 -cpu max,pauth-i

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-26 Thread Shantur Rathore
Have you tried reverting the commit I mentioned to see if that fixes the issue? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6.8 fails to boot on arm64 if any param is more tha

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-25 Thread TJ
With pr_debug() added into __parse_cmdline() there are no reports; last message is as always: EFI stub: Exiting boot services... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-25 Thread TJ
I think the cause here is staring us in the face; we have a do { ... } while(1) loop wrapping this code. The only escape are the 2 return statements. If neither trigger it'll spin, which is what the symptoms seem to indicate. 1) "-- " as a parameter 2) !len (in other words, len==0) In the first c

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-25 Thread TJ
I can reproduce the issue in a QEMU aarch64 virtual machine with both Ubuntu and Debian v6.8* kernels booting in EFI mode via GRUB, but here the length of the parameter that triggers it is 146 characters; eg: linux /boot/vmlinuz-6.8.12-arm64 root=uuid=06bc9a44-31ef-41b1-bfe1-e6383822dccd ro cons

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-25 Thread Shantur Rathore
@TJ I share your disbelief that led me to checking this 3 times. I came to this conclusion by 3 times git bisecting mainline kernel between different tags. Took me good 2 weeks to come to this conclusion but I could be wrong. To confirm this I tested this fix with mainline kernel with 24.04 and

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-25 Thread TJ
This was brought to my attention by Chris; looking at the code in commit dc3f5aae0638 parsing of an individual parameter will terminate prematurely if it is more than 255 characters and it will not be recognised as expected, with the remaining characters being parsed as an additional parameter. Fo

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-25 Thread Chris MacNaughton
At the request of iam_tj in the support:ubuntu.com Matrix room, this is the command line where I'm hitting this: nomodeset root=squash:http://10.254.131.130:5248/images/3b08252fa962c37a47d890fb5fe182b631a0c0478d758bf4573efa859cc2c548/ubuntu/arm64/ga-24.04/noble/stable/squashfs ip=sjc01-2b16-u0

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-23 Thread Shantur Rathore
I have a fix for MAAS too which I trying to get merged. https://bugs.launchpad.net/maas/+bug/2069059 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6.8 fails to boot on arm64 if

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-23 Thread Chris MacNaughton
Shantur: I'm using MAAS and encountering this on ARM64 hardware. here's hoping we can find somebody to engage to get this merged and uploaded! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Ti

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-23 Thread Shantur Rathore
Hi Chris, I have added the Merge proposal but not sure how to bring this to developers' attention. May I ask which device did you face this issue on and are you using MAAS ? Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. htt

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-23 Thread Shantur Rathore
Merge proposal - https://code.launchpad.net/~rathore4u/ubuntu/+source/linux/+git/version- seeds/+merge/469973 ** Merge proposal linked: https://code.launchpad.net/~rathore4u/ubuntu/+source/linux/+git/version-seeds/+merge/469973 -- You received this bug notification because you are a member o

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-23 Thread Chris MacNaughton
Hey Shantur, Are you uploading that patch to Noble? I'm bumping into this issue at the moment as well. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6.8 fails to boot

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-07-23 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: linux (Ubuntu Noble) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title:

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-06-19 Thread Shantur Rathore
I have added the fix here https://git.launchpad.net/~rathore4u/ubuntu/+source/linux/+git/version- seeds/commit/?h=LP2069534-140-char- fix&id=a16c19aee6d6f9b1ceb886ab835055668d662e8e -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. http

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-06-17 Thread Shantur Rathore
Hi Matthew, Not sure if I follow, The bug is already fixed in upstream in versio> 6.9-rc1 so any 6.10+ kernel will already have the it fixed. > I added a noble entry, since noble's kernel is the one that actually needs to be fixed. And the next proposed hwe 6.8 for jammy > I did have a look at

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-06-17 Thread Matthew Ruffell
Hi Shantur, It is not fixed, I just marked it as fixed for "Ubuntu" a.k.a the development release oracular, since it will pick up a 6.10+ kernel when it eventually becomes available. I added a noble entry, since noble's kernel is the one that actually needs to be fixed. I did have a look at "arm

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-06-17 Thread Shantur Rathore
Hi @Matthew Thanks for fixing the bug. Can you please let me know where can I get the fixed kernel release from? Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534 Title: linux 6.8 fails

[Bug 2069534] Re: linux 6.8 fails to boot on arm64 if any param is more than 140 chars

2024-06-17 Thread Matthew Ruffell
** Also affects: linux (Ubuntu Noble) Importance: Undecided Status: New ** Changed in: linux (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069534