[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-09-10 Thread Kai-Heng Feng
The system was returned to customer so we can't verify the SRU. ** Tags removed: verification-needed ** Tags added: verification-failed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2054391 Title:

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-26 Thread Robie Basak
Unsubscribing sponsors as there is nothing left to sponsor. ** Changed in: thermald (Ubuntu Jammy) Status: Confirmed => Fix Committed ** Tags added: verification-needed verification-needed-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subsc

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-26 Thread Robie Basak
[indent snipped] > + std::string temp_dir_path = base_path[i] + entry->d_name > + + "/"; > + DIR *temp_dir = nullptr; > + struct dirent *temp_dir_entry = nullptr; > + int len_temp_dir_entry = 0; > + int len_input = strlen("_input"); > + > + if ((temp_dir = opendir(temp_dir_p

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-26 Thread Robie Basak
** Description changed: [Impact] Some CPU sensors are not enumerated, this can make thermald deviates from the correct behavior of the CPU TDP. [Fix] Traverse all sensors under hwmon sysfs directory to make sure everything is enumerated. [Test] Check the output of thermald. Onc

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-21 Thread Christian Ehrhardt 
This all LGTM, sponsoring to jammy-unapproved $ dput ubuntu ../thermald_2.4.9-1ubuntu0.5_source.changes Uploading thermald using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu) running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries. running updatemaintainer: Stop if ubu

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-21 Thread Christian Ehrhardt 
I had two systems, none had more than two thermal zones. It was enough to outline the test a bit better, but not to show the good / bad case output. But it gave me the chance to test and install the build I had which is all fine $ sudo apt install ./thermald_2.4.9-1ubuntu0.5_amd64.deb Reading pa

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-21 Thread Christian Ehrhardt 
Local test build has been happy as well. You test description is not wrong, but a bit too incomplete for what an SRU should have. "Check the output of thermald" could use some "how exactly" and good/bad case examples. I got a system in testflinger with a modern CPU hoping it would expose this i

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-20 Thread Christian Ehrhardt 
I checked upstream git if there are any follow up fixes to the changed code we should apply right away, there are none. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2054391 Title: Fix CPU thermal

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-20 Thread Christian Ehrhardt 
The patch headers requested by Lucas are good as well now - thanks! The changelog mention of the related patch is good too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2054391 Title: Fix CPU ther

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-20 Thread Christian Ehrhardt 
I double checked if we also need to fix others e.g. mantic as often -dev releases in between are forgotten but they need to be fixed as well to avoid upgraders regressing. But that looks fine git tag --contains df8ac025d22e51c237c8ebe2aa25bf672ec04edb v2.5 v2.5.0-pre v2.5.1 v2.5.2 v2.5.3 v2.5.4

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-06-20 Thread Christian Ehrhardt 
Hi, thanks for your update. I come by looking at the sponsoring queue and will have a look... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2054391 Title: Fix CPU thermal sensors enumeration To m

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-05-06 Thread Kai-Heng Feng
DEP-3 headers and changelog entry added. ** Patch added: "thermald_2.4.9-1ubuntu0.5.debdiff" https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/2054391/+attachment/5775426/+files/thermald_2.4.9-1ubuntu0.5.debdiff -- You received this bug notification because you are a member of Ubuntu B

[Bug 2054391] Re: Fix CPU thermal sensors enumeration

2024-04-25 Thread Lucas Kanashiro
Thanks for the patch @Kai-Heng! I took a look and in general it looks good, but I'd like to ask you to add some DEP-3 headers [1] to your patch, that will give us (packagers) more context when revisiting this package for whatever reason. Now a personal opinion, I like when the patch file name is l