[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-08-22 Thread Launchpad Bug Tracker
This bug was fixed in the package samba - 2:4.6.7+dfsg-1ubuntu1 --- samba (2:4.6.7+dfsg-1ubuntu1) artful; urgency=medium * Merge with Debian unstable (LP: #1710281). - Upstream version 4.6.7 fixes the CVE-2017-2619 regression with non-wide symlinks to directories (LP: #170

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-08-22 Thread Andreas Hasenack
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/329333 ** Changed in: samba (Ubuntu) Status: Confirmed => In Progress ** Changed in: samba (Ubuntu) Assignee: (unassigned) => Andreas Hasenack (ahasenack) -- You received this

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-08-09 Thread Andreas Hasenack
** Merge proposal unlinked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/326418 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-2619 regress

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-08-03 Thread Andreas Hasenack
** Changed in: samba (Ubuntu) Assignee: Andreas Hasenack (ahasenack) => (unassigned) ** Changed in: samba (Ubuntu) Status: In Progress => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-10 Thread Andreas Hasenack
Reopening the artful task, since the fix isn't there. ** Changed in: samba (Ubuntu) Status: Fix Released => Confirmed ** Changed in: samba (Ubuntu) Assignee: Marc Deslauriers (mdeslaur) => Andreas Hasenack (ahasenack) ** Changed in: samba (Ubuntu) Status: Confirmed => In Progr

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-07 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/326418 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-2619 regressio

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-05 Thread Launchpad Bug Tracker
This bug was fixed in the package samba - 2:4.5.8+dfsg-0ubuntu0.17.04.3 --- samba (2:4.5.8+dfsg-0ubuntu0.17.04.3) zesty-security; urgency=medium * d/p/non-wide-symlinks-to-directories-12860.patch: fix a CVE-2017-2619 regression which breaks symlinks to directories on certain sys

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-05 Thread Launchpad Bug Tracker
This bug was fixed in the package samba - 2:4.4.5+dfsg-2ubuntu5.7 --- samba (2:4.4.5+dfsg-2ubuntu5.7) yakkety-security; urgency=medium * d/p/non-wide-symlinks-to-directories-12860.patch: fix a CVE-2017-2619 regression which breaks symlinks to directories on certain systems (

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-05 Thread Launchpad Bug Tracker
This bug was fixed in the package samba - 2:4.3.11+dfsg-0ubuntu0.16.04.8 --- samba (2:4.3.11+dfsg-0ubuntu0.16.04.8) xenial-security; urgency=medium [ Andreas Hasenack ] * d/p/non-wide-symlinks-to-directories-12860.patch: fix a CVE-2017-2619 regression which breaks symlinks to

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-05 Thread Launchpad Bug Tracker
This bug was fixed in the package samba - 2:4.3.11+dfsg-0ubuntu0.14.04.9 --- samba (2:4.3.11+dfsg-0ubuntu0.14.04.9) trusty-security; urgency=medium [ Andreas Hasenack ] * d/p/non-wide-symlinks-to-directories-12860.patch: fix a CVE-2017-2619 regression which breaks symlinks to

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
I filed https://bugzilla.samba.org/show_bug.cgi?id=12873 for this ACCESS_DENIED issue that happens when exporting the root filesystem ("/") and using symlinks, which is what the OP wanted fixed here but we ended up diving into https://bugzilla.samba.org/show_bug.cgi?id=12860, which is another valid

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
I get the same access denied error with 4.6.5 packages, built with or without the patch for this particular regression (#12860 upstream) (my 4.6.5 artful test packages: ppa:ahasenack/samba-merge) I think sharing the real root filesytem (/) is not a common scenario. I found one bug upstream related

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
@dgadomski confirmed. This might be a different bug. We should try with the latest samba (4.6.5) and if it continues happening there, file a bug upstream. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Dariusz Gadomski
Andreas, Marc - I think the case Dave described is not fully covered by the fix. There is a config still failing: if the share is based at / (so all symlinks in the filesystem should be local to the share) with "wide links = no" no symlinks are accessible. According to my tests this affects both:

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
** Changed in: samba (Ubuntu) Assignee: Andreas Hasenack (ahasenack) => Marc Deslauriers (mdeslaur) ** Changed in: samba (Ubuntu Xenial) Assignee: Andreas Hasenack (ahasenack) => Marc Deslauriers (mdeslaur) ** Changed in: samba (Ubuntu Yakkety) Assignee: Andreas Hasenack (ahasenack

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
** Changed in: samba (Ubuntu Xenial) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Changed in: samba (Ubuntu Yakkety) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Changed in: samba (Ubuntu Zesty) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Ch

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Graham Inggs
** Also affects: samba (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: samba (Ubuntu Yakkety) Importance: Undecided Status: New ** Also affects: samba (Ubuntu Zesty) Importance: Undecided Status: New -- You received this bug notification because

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
xenial is only affected if you use a newer kernel from hwe. For example: - linux-image-4.4.0-83-generic: unaffected - linux-image-4.8.0-58-generic: affected -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bug

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
Here, let me update with a simple test case: a) Add this share: [tmp] path = /tmp wide links = no follow symlinks = yes browseable = yes read only = no guest ok = yes b) run: mkdir /tmp/target ln -sf /tmp/target /tmp/symlink-to-target c) failing te

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
I haven't seen an issue with symlinks to files. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-2619 regression breaks symlinks to directories To manage notifications about th

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Andreas Hasenack
Fix confirmed for artful, test packages here: ppa:ahasenack/samba-dir- symlink-1701073 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-2619 regression breaks symlinks to direct

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-07-03 Thread Dave Kettmann
@Andreas -- I found that symlinks to files are also broken, not just directories. Did you find this too? This was both linux and Windows, I would get an Access Denied error. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks to directories

2017-06-30 Thread Andreas Hasenack
Testing this branch for artful: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+ref /artful-samba-dir-symlink-1701073 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-30 Thread Andreas Hasenack
Confirmed. The bug will happen wherever opening a symlink to a directory with O_DIRECTORY||O_NOFOLLOW returns ENOTDIR instead of ELOOP (and you have to be using protocol SMB2 or higher): xenial: andreas@nsn7:~$ mkdir -p /tmp/cve/a andreas@nsn7:~$ ln -s /tmp/cve/a /tmp/cve/b andreas@nsn7:~$ python

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-30 Thread Andreas Hasenack
Note: if you use smbclient with -m SMB2, which is what windows7+ uses, you will see the same failure when doing "ls /opt/opt/*": root@xenial-samba-symlink-1701073:~# smbclient //localhost/cve-root -U ubuntu%ubuntu -c "ls /opt/opt/*" WARNING: The "syslog" option is deprecated Domain=[WORKGROUP] OS

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-30 Thread Andreas Hasenack
Ok, checking out what's going on here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-2619 regression breaks symlinks To manage notifications about this bug go to: https://bu

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-30 Thread Dave Kettmann
Shell script attached to be run on fresh install of Xenial. Powershell commands to test functionality below: Set-Location \\smb-xenial\reproducer\opt\root Get-ChildItem Set-Location \\smb-xenial\reproducer\opt\opt Get-ChildItem Get-Content \\smb-xenial\reproducer\opt\smb.conf The first location

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-30 Thread ChristianEhrhardt
Adding update-regression until provde that it is not. It is too late to stop the updates with that (~3 months) but still tagging correctly seems right. @Marc - since you backported the CVE could you take a look? @Dave - Could you share your testcase (I assume you have a script of some sort) @An

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-29 Thread Dave Kettmann
I have setup 4 reproducer VMs. All running the base OS and installed only required packages for Samba. Here are the results: SMBClient Xenial Yakkety Zesty Artful Link to rootY Y Y Y Link to directory Y Y Y Y Link to file

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-29 Thread Andreas Hasenack
I didn't quite dive into this yet. Adding https://bugzilla.samba.org/show_bug.cgi?id=12721 which may also be related. ** Bug watch added: Samba Bugzilla #12721 https://bugzilla.samba.org/show_bug.cgi?id=12721 ** Tags added: server-next -- You received this bug notification because you are a

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-29 Thread Dariusz Gadomski
** Also affects: samba via https://bugzilla.samba.org/show_bug.cgi?id=12860 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-261

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-28 Thread Hans Joachim Desserud
** Tags added: xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-2619 regression breaks symlinks To manage notifications about this bug go to: https://bugs.launchpad.net/

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-28 Thread Dave Kettmann
** Changed in: samba (Ubuntu) Importance: Undecided => High ** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2017-2619 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CV

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-28 Thread Dave Kettmann
Related bugs: https://bugzilla.samba.org/show_bug.cgi?id=12860 and https://bugzilla.samba.org/show_bug.cgi?id=12496 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1701073 Title: CVE-2017-2619 regr

[Bug 1701073] Re: CVE-2017-2619 regression breaks symlinks

2017-06-28 Thread Dave Kettmann
Further investigation shows that these regressions seem to be related to this in the upstream source: https://github.com/samba-team/samba/commits/v4-6-test/source3/smbd/dir.c This is a series of 7 commits related to the above-referenced CVE in this file. ** Bug watch added: Samba Bugzilla #12860