[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-05-10 Thread Peter Eckersley
Apologies for the delay here :( The Certbot locking patch turned out to be more subtle to implement correctly than we had expected, but we finalised and version and shipped it in Certbot 0.14.0 last week. The patch is here: https://github.com/certbot/certbot/pull/4449#issuecomment-299802507 Since

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-22 Thread Peter Eckersley
Here's a slightly better link: https://github.com/certbot/certbot/pull/4369 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.9.3 To manage notifications abo

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-22 Thread Peter Eckersley
We have the mitigation in our git master tree (https://github.com/certbot/certbot/pull/4394/files) and are shipping it in an 0.12.1 release today to get field testing. Once that patch has been used to issue ~100K certs I'd be okay with it going into an SRU. -- You received this bug notification b

Re: [Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-17 Thread Chris Halse Rogers
Mitigation 0 gets a +1 from me. That seems the sensible path. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.9.3 To manage notifications about this bug go

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-16 Thread Nish Aravamudan
>From a fear of breaking existing deployments in an update -- I would also prefer #0. Robie is out this week, so maybe RAOF, you can you provide your input here? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.n

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-16 Thread Brad Warren
Small update: If we go with mitigation 0, we won't be using python- filelock. We'll either use an existing Python file locking module packaged in Ubuntu or add our own code that implements lockfiles to Certbot. -- You received this bug notification because you are a member of Ubuntu Bugs, which i

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-15 Thread Peter Eckersley
Hi Chris! I think your todo list looks accurate. On the question of cron jobs, here are the answers as we understand them upstream: What happens if the user runs two multiple cron jobs? Answer 0: probably nothing. "certbot renew" is designed to be run as often as you like, and is normally a no-

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-14 Thread Chris Halse Rogers
Aaargh. Time! Robie, if someone on the server team has some spare cycles to prepare the packages, that'd be great. Sorry! There's still the question - “What happens if a user has installed letsencrypt outside of packaging? Will the new cron job cause any problems?” to be resolved, too. -- You r

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-14 Thread Chris Halse Rogers
Aaargh. Time! Robie, if someone on the server team has some spare cycles to prepare the packages, that'd be great. Sorry! There's still the question - “What happens if a user has installed letsencrypt outside of packaging? Will the new cron job cause any problems?” to be resolved, too. -- You r

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-02 Thread Chris Halse Rogers
OK. So, my understanding of the current state is that: a) I shall update the SRU packages (in git and upload to the queue): *) Run update-maintainer *) Add a NEWS entry for the new cron job *) Possibly update to 0.10.2 b) Robie will then do the SRU-review for them. That leaves the question: “W

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-03-02 Thread Brad Warren
Here's a link to the changelog: https://github.com/certbot/certbot/blob/master/CHANGELOG.md -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.9.3 To manage

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-02-22 Thread Robie Basak
I'd like to suggest again that everyone involved does all packaging changes in git, and gets all approvals (from a suitable Ubuntu uploader and the Ubuntu SRU team) in git, before uploading. I really think this will speed things up. I'm not sure I see everything in https://alioth.debian.org/plugin

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-02-22 Thread Peter Eckersley
This has been stuck for a while, I suspect because it hasn't been clearly on anyone's plate :(. Let's fix that: * Brad Warren on the Certbot team is going to construct a retrospective changelog.txt, and post a link here. * RAOF should probably revise the packages to include that and the news fil

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-02-02 Thread Brian Murray
** Changed in: python-certbot-apache (Ubuntu Yakkety) Status: In Progress => Incomplete ** Changed in: python-certbot (Ubuntu Yakkety) Status: In Progress => Incomplete ** Changed in: python-acme (Ubuntu Yakkety) Status: In Progress => Incomplete -- You received this bug no

[Bug 1640978] Re: [SRU] Backport letsencrypt 0.9.3

2017-01-31 Thread Robie Basak
I spent some time on reviewing this on Friday, but I got interrupted. There was also some discussion on IRC (https://irclogs.ubuntu.com/2017/01/27/%23ubuntu-release.html#t12:31) My notes: Can we put a note that there will be a new cronjob active now in debian/NEWS and debian/changelog as suggeste