[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-15 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-control-center - 1:2.24.0.1-0ubuntu5 --- gnome-control-center (1:2.24.0.1-0ubuntu5) intrepid; urgency=low * debian/patches/95_desktop-effects-integration.patch: - change by Bruce Cowan to allow selecting the desktop effects only when

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-13 Thread Bruce Cowan
This isn't actually my bug, but I've hijacked it now. Indeed hiding the tab's contents is better (I remember something in the HIG about that), so here's a new patch. ** Attachment added: "Yet another patch" http://launchpadlibrarian.net/18500219/only_show_effects_if_compiz_available.debdiff

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-13 Thread Michael Vogt
Thanks for your bugreport and your patch, I would prefer if instead of hidding the tab the compiz settings would be set "set_sensivite(False)". Even better would be if we could offer to install compiz if the user clicks on it, but that is probably jaunty material. If you could update the patch to

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-08 Thread Bruce Cowan
The above debdiffs doesn't actually work, as the tab wasn't actually hidden. (effects_init doesn't show the tab like I thought it did) Here's one which works. ** Attachment added: "Working debdiff" http://launchpadlibrarian.net/18349632/only_show_effects_if_compiz_available.debdiff -- Appear

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-08 Thread Bruce Cowan
Actually, there is a typo in the changelog, "only show effects tab is compiz is installed" should be "only show effects tab if compiz is installed" -- Appearance Preferences offer Visual Effects without installed Compiz https://bugs.launchpad.net/bugs/159996 You received this bug notification bec

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-08 Thread Bruce Cowan
** Attachment added: "Updated debdiff" http://launchpadlibrarian.net/18347666/only_show_effects_if_compiz_available.debdiff -- Appearance Preferences offer Visual Effects without installed Compiz https://bugs.launchpad.net/bugs/159996 You received this bug notification because you are a memb

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-08 Thread Sebastien Bacher
there is a new version available in intrepid, could you update the debdiff? -- Appearance Preferences offer Visual Effects without installed Compiz https://bugs.launchpad.net/bugs/159996 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. --

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-06 Thread Bruce Cowan
It was just the output of cdbs-edit-patch and debdiff. In fact, it only touches two files, debian/changelog and debian/patches/95_desktop- effects-integration.patch, it's just that this patch patches a patch. -- Appearance Preferences offer Visual Effects without installed Compiz https://bugs.lau

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-10-06 Thread Bryce Harrington
Hi Bruce, In general the patch looks okay, but I notice it touches a lot of other files unnecessarily. It appears you constructed the diff between two different versions of g-c-c. Would you mind redoing the patch more cleanly, so it doesn't touch so many files? ** Changed in: gnome-control-cent

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-09-24 Thread cybernoid
This is what I call 'cracked by angels' ;))) In fact I realise this is a VERY ANNOYING bug, special to women (My wife included). They all would like to see the compyz going on with their portable x86, but I realize that theres a lot of portable computers with no 3D acceleration!!! In fact 50% of

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-09-24 Thread Bruce Cowan
This debdiff disables the "effects" tab if the command "compiz" isn't found. ** Attachment added: "Patch" http://launchpadlibrarian.net/17931341/only_show_effects_if_compiz_available.diff -- Appearance Preferences offer Visual Effects without installed Compiz https://bugs.launchpad.net/bugs/

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-09-24 Thread Bruce Cowan
Disabling the tab when compiz is not installed would be quite easy. Just a case of checking for NULL from g_find_program_in_path ("compiz"). I'll have a crack at doing this. -- Appearance Preferences offer Visual Effects without installed Compiz https://bugs.launchpad.net/bugs/159996 You received

[Bug 159996] Re: Appearance Preferences offer Visual Effects without installed Compiz

2008-07-28 Thread Sebastien Bacher
** Changed in: gnome-control-center (Ubuntu) Importance: Undecided => Low Assignee: (unassigned) => Ubuntu Desktop Bugs (desktop-bugs) Status: New => Confirmed -- Appearance Preferences offer Visual Effects without installed Compiz https://bugs.launchpad.net/bugs/159996 You receive