[Bug 1547466] Re: grep switches into binary mode while processing a text file under the C locale

2018-01-27 Thread Moses Moore
I just tripped over something like this with grep v3.1-2 (Ubuntu 17.10 "artful"). the LC_ALL setting did not make a difference, and grep 3.1 passes the "test case" described in the bug description. I have many text files, but one of them had a string of 49 \x00 chars. What confused me was the s

[Bug 1547466] Re: grep switches into binary mode while processing a text file under the C locale

2016-06-10 Thread Martin Pitt
** Summary changed: - grep switches into binary mode while processing a text file + grep switches into binary mode while processing a text file under the C locale -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-06-08 Thread Launchpad Bug Tracker
This bug was fixed in the package grep - 2.25-1~16.04.1 --- grep (2.25-1~16.04.1) xenial-proposed; urgency=medium * New upstream release. - Don't switch into binary mode when encountering non-ASCII characters and running in the C locale. (LP: #1547466) -- Martin Pitt T

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-06-08 Thread Stefan Bader
Verified in Xenial. grep-2.24-1: #> echo Hello Wörld|LANG=C grep Hello Binary file (standard input) matches grep-2.25-1~16.04.1: echo Hello Wörld|LANG=C grep Hello Hello Wörld ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because yo

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-06-07 Thread Mathew Hodson
** Changed in: grep (Ubuntu Xenial) Importance: Undecided => High ** Tags added: regression-release -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches into binary mode wh

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-29 Thread teo1978
> This has been the case for a long time. Nope. Just a few months. > If you try to show non-UTF-8 > data in an UTF-8 locale you'll just see garbage (or other encoding > mismatches) That doesn't mean that the file should be processed as binary. Also, previous to the regression, grep would work as

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-29 Thread Timo Aaltonen
Hello Stefan, or anyone else affected, Accepted grep into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grep/2.25-1~16.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ub

Re: [Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-28 Thread Martin Pitt
teo1978 [2016-04-28 22:08 -]: > Most of the times, text files that are incorrectly processed as binary > are ISO-8859-whatever encoded while files that are matched like text as > expected are utf8-encoded (my locale is utf8). This has been the case for a long time. If you try to show non-UTF-8

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-28 Thread teo1978
@Brian Murray, I resubscribed you because you marked this issue as duplicate of #1535458, I asked you if you could confirm because that seems doubtful and you didn't reply, and now at 1535458 they say it only affects xenial, while this one I am observing on wily. -- You received this bug notifica

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-28 Thread teo1978
Well, I have wily and I am observing this bug all the time (starting from a few months ago), or at least I was told that what I'm observing was a duplicate of this bug. What I see is that when I grep text files, randomly (but the same files will consistently produce the same results) text files a

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-28 Thread teo1978
Sorry, meant to post this on the other bug -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches into binary mode while processing a text file To manage notifications about thi

Re: [Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-28 Thread Martin Pitt
teo1978 [2016-04-28 20:26 -]: > And what about wily?? This bug does not affect wily at all. It was introduced in grep 2.23 and still present in 2.24, earlier/later versions are not affected. Wily has 2.21. -- You received this bug notification because you are a member of Ubuntu Bugs, which i

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-28 Thread teo1978
> Therefore my recommendation is to drop this hackery-patchery and just upgrade xenial to grep 2.25 instead. And what about wily?? Wily hasn't reached EOL (plus xenial shouldn't have been released in the first place, bricking people's computers on upgrade or leaving them with a non working mouse

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-27 Thread Bug Watch Updater
** Changed in: grep (Debian) Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches into binary mode while processing a text file To manag

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-27 Thread Martin Pitt
** Description changed: I noticed this staring to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to grep suddenly acting weird. When not having any language set (or a non

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-27 Thread Martin Pitt
I tried to backport http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=b7bc3c1a4 ; this by itself does not apply as this changes the files lib/hard-locale.[ch] (which aren't present at all in grep 2.24) and also has a lot of changes to files that aren't contained in grep. I got a backport now,

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-27 Thread Martin Pitt
** Description changed: - I noticed this starting to happen in Xenial about two days ago. When + I noticed this staring to happen in Xenial about two days ago. When running sbuild (or now the buildd, too), the build breaks when trying to compile a generated file. I traced the problem down to g

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-27 Thread Martin Pitt
This is fixed in grep 2.25, which is in yakkety. ** Bug watch added: Debian Bug tracker #800670 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800670 ** Also affects: grep (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800670 Importance: Unknown Status: Unknown *

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-25 Thread Martin Pitt
Ah, thanks for pointing out. I understood it as the changes in grep 2.23 were deliberate, and during xenial this caused quite a lot of fallout which we fixed. Reverting the behavior for C makes sense. Thus now we still need to find the actual fix in gnulib. Applying the doc and test to grep itself

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-25 Thread Brian Murray
** Changed in: grep (Ubuntu) Assignee: (unassigned) => Martin Pitt (pitti) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches into binary mode while processing a text fi

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-22 Thread bizdelnick
I'm sorry for the wrong commit link. The real fix is gnulib update: http://git.savannah.gnu.org/cgit/grep.git/commit/?id=9746ea261225558a5ad150936dbe822ede565304 The commit I mentioned above just documents changes and adds a test. -- You received this bug notification because you are a member of

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-04-22 Thread bizdelnick
This bug is likely to be fixed upstream: http://git.savannah.gnu.org/cgit/grep.git/commit/?id=d8a366218f0b44a52c0b212d65d9ebb04e46b3dc Please apply the fix to Xenial package. This bug breaks innumerable scripts that were working correctly in C locale earlier. -- You received this bug notificatio

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-03-11 Thread Brian Murray
** Tags added: rls-x-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches into binary mode while processing a text file To manage notifications about this bug go to:

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-03-08 Thread Stefan Bader
While it is good to have the builders fixed, there is one worrying aspect to this: this may happen to anything using grep and modifies the output in an unexpected way while still returning a zero return code. For example: echo -e "Hello\nWörld" | LANG=C grep -v xxx; echo $? will no longer return

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-03-08 Thread Colin Watson
Just in case it confuses anyone, the fix for https://bugs.launchpad.net /launchpad-buildd/+bug/1552791 was rolled out at the end of last week, but you can no doubt still reproduce this in a local sbuild instance or similar. -- You received this bug notification because you are a member of Ubuntu

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-03-02 Thread Brian Murray
** Tags added: wily -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches into binary mode while processing a text file To manage notifications about this bug go to: https://bu

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-03-02 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: grep (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-03-02 Thread Stefan Bader
Here is some upstream discussion about it for reference: http://lists.gnu.org/archive/html/bug-grep/2016-02/msg00047.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches i

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-03-02 Thread Olivier Tilloy
This seems to be the root cause of bug #1551145 too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547466 Title: grep switches into binary mode while processing a text file To manage notifications

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-02-26 Thread Stefan Bader
The current version of grep was published on 2016-02-18 which could be around when sbuild broke for me. Did not notice immediately as I was working on something so I used the chroots directly (which works as there I have a UTF-8 setting there which sbuild deliberately drops). I downgraded grep i

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-02-25 Thread Stefan Bader
Should add, when this first happened I asked someone else on the team to check the package build. That was someone in the US, so there at least would be no special keyboard setting, only the system language which defaults to en_US.UTF-8. -- You received this bug notification because you are a mem

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-02-25 Thread Stefan Bader
I was wondering the same when you could not reported that it does not happen for you. So I did use wget to pull it to another host from LP. The result was what I posted in comment #3. That system was a fresh install (not an upgrade) using the default system language (though German keyboard and time

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-02-25 Thread Brian Murray
Yes, I followed the test case you gave in the description. Perhaps this is related to bug 1535458 and uploading the file to LP changed the file type? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/15474

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-02-24 Thread Stefan Bader
Brian, did you set a non-UTF language? apt-cache policy grep grep: Installed: 2.23-1 Candidate: 2.23-1 Version table: *** 2.23-1 500 500 http://de.archive.ubuntu.com/ubuntu xenial/main amd64 Packages 100 /var/lib/dpkg/status LANG=C grep -v xxx grant_table.h ... * table are

[Bug 1547466] Re: grep switches into binary mode while processing a text file

2016-02-24 Thread Brian Murray
I was unable to recreate the problem given the test case provided and the following version of grep: $ apt-cache policy grep grep: Installed: 2.23-1 Candidate: 2.23-1 Version table: *** 2.23-1 500 500 http://mirrors.cat.pdx.edu/ubuntu xenial/main amd64 Packages 100 /var/lib