** Changed in: zfs-initramfs (Ubuntu)
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications
The right fix is here:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1527727
If you bring 0.6.5.6 and patch Ubuntu's GRUB to set that environment
variable, then the udev rules can go away entirely.
Otherwise, as to the debdiff in #38, it is fine, but the "raid"
condition is unnecessary
I don't see why we would need have ENV{ID_FS_USAGE}=="raid", wouldn't
ENV{ID_FS_TYPE}=="zfs_member" suffice?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=Z
Sorry, I've been out of the loop for a couple of weeks because of an
operation. So just checking, is the debdiff in comment #38 ok by you
Richard?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
As far as I know, it's not a necessary condition. It's the first time
I've seen it in a zfs_member udev rule.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=
Richard, It was on all the zpool devices I checked with "udevadm info",
and seemed to be related to the filesystem contents. That's all. Why?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Titl
Why do you have ENV{ID_FS_USAGE}=="raid"?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications about this bug go to:
https://bugs.lau
You're right, richard. The right thing to do is to fix grub. Having
these rules at all is Wrong. Once grub is fixed, we will rip these out.
We won't need to support them at all then.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
http
Make this work, even for MBR disklabel, and GPT disklabel with wrong
partition type id.
Neither the disklabel kind nor the partition type id are a necessary
part of creating ZFS pools, We shouldn't require it here too.
** Patch added: "debdiff against ubuntu xenial"
https://bugs.launchpad.net
@colin-king: It looks like we were commenting at the same time.
Including *both* rules is not harmful in any *technical* way. The only
concern I have is that then you're "supporting" other partition types,
which may "obligate" you to do that "forever" (quotes because none of
these things are litera
@Richard, do you have any views on this potential fix?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications about this bug go to:
htt
OK, if you attach a debdiff I'll apply this for the next upload
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications about this bug g
Chad, I'm not opposed to Ubuntu including both, but if you look at the
comment history, you'll see that I switched from zfs_member to the
partition type for a reason. `zpool create` doesn't trigger udev,
whereas partitioning tools do (by triggering the kernel to re-read the
partition table). As a r
** Attachment added: "60-zpool.rules"
https://bugs.launchpad.net/ubuntu/+source/zfs-initramfs/+bug/1530953/+attachment/4578296/+files/60-zpool.rules
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/15
ZFS is so new to Linux that the paritioning tools we have don't have a
ZFS in the Linux section of GPT partition types. We can find it in
FreeBSD, Solaris, and Apple.
Someone is likely to pick something with Linux in the name like Linux
Filesystem. That would be wrong for this patch.
The FreeBSD
** Changed in: zfs-initramfs (Ubuntu)
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications
Yes, that works fine.
I'm seeing deadlocks on 0.6.5.4, but that has nothing to do with this
change.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To
If you can test the ~4 and let us know if that's good, then please do,
otherwise I can't upload it.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To m
Thanks again Richard, I've uploaded ~4 to the PPA and it's ready for
testing.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications a
I've attached a new 60-zpool.rules. Instead of matching on
ENV{ID_FS_TYPE}=="zfs_member", it uses ENV{ID_PART_ENTRY_SCHEME}=="gpt",
ENV{ID_PART_ENTRY_TYPE}=="6a898cc3-1dd2-11b2-99a6-080020736631".
That is, it matches based on the partition type. This way, the rule
matches when the partition is cre
Hi Richard, thanks for the patch, I've applied this and made the
changelog entry change and uploaded a ~3 version in ppa:colin-
king/zfs-0.6.5.4-alpha - if you don't mind a further test on this and
if it looks good I'll get it pushed.
--
You received this bug notification because you are a membe
Also, the changelog entry for the udev rules file is wrong. The correct
filename is: /lib/udev/rules.d/60-zpool.rules
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's nati
We still need the `udevadm trigger` so the udev rule applies without a
reboot. Attached is a debdiff. This postinst follows the pattern that
other packages use. I've verified that it has the desired effect.
** Patch added: "zfs-initramfs-udevadm.debdiff"
https://bugs.launchpad.net/ubuntu/+sour
Thanks for the patch Richard. I've uploaded ~2 to the PPA and it should
be ready for testing in a short while. Let me know if this works OK and
then I can re-test this on monday and sync it to Xenial.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscri
Attached is a debdiff relative to the alpha PPA. This is the last of the
changes I have already implemented for the boot process.
It reworks the zfs initramfs script to more closely follow the upstream
Debian (non-zfs) initramfs scripts. Instead of using a ZFS-specific
/etc/default parameter to ad
Actually, it looks like we need a `udevadm trigger` in zfs-initramfs's
postinst script. Installing the package does not currently result in
those devices appearing.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad
This looks solid. One thing I wanted to note... putting the udev rules
in zfs-initramfs means that someone installing a system needs to install
zfs-initramfs outside of the chroot. If that file was in zfsutils-linux,
they wouldn't have to install the extra package. For my HOWTO, it
doesn't really m
Richard, I've put your changes into the 0.6.5.4 and uploaded it into the
following test ppa: https://launchpad.net/~colin-
king/+archive/ubuntu/zfs-0.6.5.4-alpha
Do you mind giving this a test and if it looks sane I'll upload it next
week.
--
You received this bug notification because you are a
I'll roll this into Xenial zfs-linux after we've got 0.6.5.4 uploaded
(hopefully sometime this week).
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
T
I'm attaching a debdiff which outlines the changes necessary to ship a
rules.d file. It uses proper numbering in the name, is installed in the
right place, and has the right rule. I've tested the package with this
change applied. It also has a comment explaining what it does and why
it's necessary.
I am not sure whether adding an udev rule that may (or may not, if not
using wholedisk) work is a good idea.
Although, until grub's behavior is fixed shipping a sensible workaround
seems useful, if the rule file can include a bit of documentation like a
short explanation why it is necessary and co
Actually, I think the numbering for that udev file should NOT be in the
90s. I think the 90s are for the system administrator. So we probably
want 60-zfs-vdev.rules if it's shipped by the package.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed t
Can you also ship an /etc/udev/rules.d/90-zfs-vdev.rules with these
contents?
KERNEL=="sd*[0-9]", IMPORT{parent}=="ID_*",
ENV{ID_FS_TYPE}=="zfs_member",
SYMLINK+="$env{ID_BUS}-$env{ID_SERIAL}-part%n"
This makes GRUB work if the user uses /dev/disk/by-id/x names, which
upstream ZFS-on-Linux recomm
As a sidenote, this coupled with #1530457 should bring full support for
a standard and portable rpool setup to Ubuntu, making it one of the
first distributions that is able to boot natively off a pool with all
currently implemented ZFS feature flags enabled/active.
--
You received this bug notifi
Followed the excellent instructions in
https://github.com/rlaager/zfs/wiki/HOWTO-Install-Ubuntu-to-a-Native-
ZFS-Root-Filesystem and using the updated zfs-initramfs package I can
now boot just using root=ZFS=rpool/ROOT/ubuntu ro
Thanks for the patch, I'll get this uploaded into Xenial
** Changed
** Changed in: zfs-initramfs (Ubuntu)
Status: In Progress => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications a
Sorry about that, stupid mistake by me.
I've uploaded a new version into a different PPA, can you check this now
works?
ppa:colin-king/zfs-xenial-lp1530953
Thanks
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpa
In my original patch, I added BOOT=zfs code to conf.d/zfs. In your
package, you have that code in conf-hooks.d/zfs instead.
I installed the package from your PPA. It does not work. If I move the
code from conf-hooks.d/zfs to conf.d/zfs, then it works.
Here's my HOWTO for doing a ZFS root install:
Richard,
I've applied the change and uploaded it to my ppa:colin-king/zfs-xenial-
experimental
I would appreciate it if you can test this for me, and for reference, explain
the testing procedure you used so I can try this myself.
The build package should be ready to test by 17:00 UTC.
Colin
--
Thanks for the update Richard.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications about this bug go to:
https://bugs.launchpad.net/
(13:17:38) rlaager: ryao: Your comment on
https://github.com/zfsonlinux/pkg-zfs/pull/140 is seeming to give the Ubuntu
maintainer pause about accepting that patch. My position is that pool namespace
collisions are a separate issue (which will require changes to GRUB as well),
and that the patch
If we want to try to handle pool name collisions (and frankly, I'm not
convinced that we need to), that's a separate issue. That would involve
changing GRUB as well. This patch is a good improvement on its own. If
we want to enhance things more later, we can do that.
--
You received this bug noti
Looking at the commit, is there any reason that this has not been
accepted by upstream?
Noting comment by ryao on 2 Oct 2015:
"If I recall correctly, the root=ZFS=$DATASET syntax is myself and
either @dajhorn or @rlaager agreed to use to adopt as something of a
standard back in 2012. I would like
Upstream commit info: https://github.com/zfsonlinux/pkg-zfs/pull/140
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title:
Support GRUB's native root=ZFS=
To manage notifications about this
Which release are you filing the bug against?
** Changed in: zfs-initramfs (Ubuntu)
Assignee: (unassigned) => Colin Ian King (colin-king)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Ti
** Also affects: grub
Importance: Undecided
Status: New
** Changed in: zfs-initramfs (Ubuntu)
Importance: Undecided => Medium
** No longer affects: grub
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launch
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: zfs-initramfs (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1530953
Title
The attachment "grub-native-root-syntax.patch" seems to be a patch. If
it isn't, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if you are a member of the ~ubuntu-reviewers,
unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by
** Description changed:
Upstream GRUB sets root=ZFS=rpool/path/to/rootfs by default. By
supporting that syntax (while retaining the existing support for
backwards compatibility), we can work out-of-the-box.
I've attached a patch for zfs-initramfs to implement this. Note that
since thi
49 matches
Mail list logo
