[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-10-15 Thread Michi Henning
** Changed in: thumbnailer (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To manage notifications a

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-31 Thread Pat McGowan
** Changed in: canonical-devices-system-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-17 Thread Bill Filler
** Changed in: canonical-devices-system-image Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-17 Thread James Henstridge
Since "requesting the same image multiple times" isn't quite the same problem, I filed bug 1485490 and linked my branch to it there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-16 Thread James Henstridge
The repeated reloading of thumbnails is due to gallery-app appending Date.now() to the image://thumbnailer URI. I've put together an MP that should fix this while still requesting new thumbnails when the file contents change here: https://code.launchpad.net/~jamesh/gallery-app/thumbnail- mtime/+m

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-16 Thread Michi Henning
BTW, the number of duplicate requests seems to depend on the current layout of the event list. Sometimes I see two requests, sometimes five, sometimes a dozen. If you don't see what I'm describing, add a single photo at a time and try again. It seems to be worst when a single photo "sticks out" at

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-16 Thread Michi Henning
I just tried with image 217 from rc-proposed, and things look much better now. I don't see the invalid sizes anymore. However, when pulling left when I'm at the end of my event list, I still get multiple requests for the same thumbnail. Right now, I'm seeing 18 requests for the same thumbnail bein

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-16 Thread Launchpad Bug Tracker
This bug was fixed in the package gallery-app - 0.0.67+15.10.20150806-0ubuntu1 --- gallery-app (0.0.67+15.10.20150806-0ubuntu1) wily; urgency=medium [ Arthur Mello ] * Fix the use of actionManager.localContexts to match last changes on it (LP: #1481920) * Fix thumbnail reque

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-13 Thread Arthur Mello
No, it was published. The fix should be on the rc-proposed image already -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To manage notifica

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-13 Thread Michi Henning
I don't have a krillilng, only a mako. I can test again with that. I'll grab the latest rc-proposed image and your gallery version. (It's still in the silo, I take it?) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launc

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-13 Thread Arthur Mello
I tested on krillin (r94) with gallery (2.9.1.1232) and I am not able to see any invalid size request. We have multiple requests while loading events with different sizes (none invalid) for the same delegate but that is related with the current implementation of the event list andwe are working

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-12 Thread Bill Filler
we have released the fix in latest gallery click package 2.9.1.1232 @artmello please verify if the issue in comment #8 is still present -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: L

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-09 Thread Michi Henning
OK, I set it back to "Confirmed". I believe the issues in comment #8 are still there. If not, someone please set me straight! :-) ** Changed in: canonical-devices-system-image Status: Fix Committed => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-08 Thread Pat McGowan
Not sure I saw a vivid landing with the bug referenced, reopen if not fixed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To manage notif

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-07 Thread Michi Henning
Pat, are you sure that's really fixed? Three days ago, when I tested from the silo, there were still problems (see comment #8). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of t

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-07 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/wily-proposed/gallery-app -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To manage notifications about this bu

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-07 Thread Pat McGowan
** Changed in: canonical-devices-system-image Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size T

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-05 Thread Michi Henning
** Description changed: - When using the ballery app, the thumbnailer gets loads of requests with + When using the gallery app, the thumbnailer gets loads of requests with QSize(-1,-1), for example, when opening the gallery app. The problem with this is that the thumbnailer interprets this

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-08-04 Thread Michi Henning
I just downloaded the PPA from silo 4 and tried it on Mako. I'm still seeing lots of requests with invalid size (-1, -1). To reproduce, take a few photos and videos, run "thumbnailer-admin clear", and start the gallery-app. Looking at ~/.cache/upstart/application-click- com.ubuntu.gallery_galler

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-28 Thread Michi Henning
OK, so that explains the video thumbnails, thanks! I think it's OK to ask for whatever images you actually want to display. I mean, after all, that's what the thumbnailer is for. If you were to always ask for some fixed size, then each and every time the thumbnail needs to be displayed, the GPU ha

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-28 Thread Arthur Mello
When we tap in a photo, we are in fact opening a list of media that user can navigate when swiping right and left. The fact that we are seeing requests for videos when opening a photo is related with the way this list cache is implemented in gallery. With the new MR linked here, gallery should not

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-27 Thread Launchpad Bug Tracker
** Branch linked: lp:~artmello/gallery-app/gallery-app- thumbnailer_wrong_request -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To manage

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-27 Thread Arthur Mello
** Changed in: gallery-app (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To manage notif

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-24 Thread Bill Filler
** Changed in: canonical-devices-system-image Importance: Undecided => High ** Changed in: canonical-devices-system-image Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-20 Thread Bill Filler
confirmed, seeing the invalid QSize in the gallery log ** Changed in: gallery-app (Ubuntu) Status: New => Confirmed ** Changed in: canonical-devices-system-image Milestone: None => ww34-2015 ** Changed in: canonical-devices-system-image Assignee: (unassigned) => Bill Filler (bfil

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-16 Thread Michi Henning
We made a last-minute change to treat invalid QSize requests as 128x128, so the -1, -1 requests no longer show up in dubs.log. However, if you look in ~.cache/upstart/application-click- com.ubuntu.gallery_gallery_2.9.1.1209.log, you'll see tons and tons of invalid QSize requests. We are planning

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-15 Thread Bill Filler
I'm not seeing any requests for -1 in dbus.log using thumbnailer from silo 10, but we have not changed the code in Photo Roll at all so not sure why the problem is not occuring. @michi Would you mind retesting with the latest rc-proposed image with silo 10 installed? -- You received this bug no

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-07-15 Thread Sebastien Bacher
Hey Arthur, I saw that you landed some changes recently [1] around thumbnailer use, could you check if that has to do with the issue described there? [1] https://code.launchpad.net/~artmello/gallery-app/gallery-app- disable_gallery_photo_component/+merge/263818 ** Project changed: gallery-app =>

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-06-24 Thread Michi Henning
** Tags added: invalid-qsize -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1467743 Title: Lots of thumbnail requests with invalid size To manage notifications about this bug go to: https://bugs.lau

[Bug 1467743] Re: Lots of thumbnail requests with invalid size

2015-06-23 Thread Michi Henning
It looks like this seriously affects the user experience too. Take about 40-50 photos. Run gallery-app. Go to the photo roll. Scroll up and down until all the thumbnails have been generated. (This loads up the cache.) Run tail -f ~/.cache/upstart/dbus.log on the phone. Now scroll up and down in