[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2020-01-30 Thread Dave Jones
** Description changed: + Impact + == + + Under most circumstances, the impact is minimal (a few extra redundant + comment lines in apt sources. However, if users are automating source + removal / addition on a machine (as in comment 11), there is the + potential to wind up with an excessivel

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2020-01-20 Thread Julian Andres Klode
** Also affects: python-apt (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: software-properties (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: python-apt (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: software-p

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2020-01-09 Thread Launchpad Bug Tracker
This bug was fixed in the package python-apt - 1.9.3ubuntu2 --- python-apt (1.9.3ubuntu2) focal; urgency=medium * Revert "apt.Cache: cache apt.package.Origin objects by id" -- Julian Andres Klode Tue, 17 Dec 2019 19:24:36 +0100 ** Changed in: python-apt (Ubuntu) Status:

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-12-06 Thread Dave Jones
I have an updated patch available from the following branch for focal: https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git /python-apt/+ref/fix-dupe-ppa Currently building a test package in the following PPA: https://launchpad.net/~waveform/+archive/ubuntu/python-apt/+pa

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-09-17 Thread Peter Sabaini
Julian, unfort. testing the patch above against a bionic system didn't help, I'm still getting duplicate deb-src entries # deb-src http://ppa.launchpad.net/juju/stable/ubuntu bionic main # deb-src http://ppa.launchpad.net/juju/stable/ubuntu bionic main # deb-src http://ppa.launchpad.net/juju/stab

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-08-27 Thread Francis Ginther
** Tags added: id-5d65087107d6ae450d988462 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines To manage notifications abo

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-08-27 Thread Julian Andres Klode
Can you check the patch I posted in comment #10? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines To manage notificatio

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-08-27 Thread Peter Sabaini
Subscribing field-medium, we're seeing this repeatedly -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines To manage notif

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-07-08 Thread Julian Andres Klode
** Changed in: python-apt (Ubuntu) Importance: Low => Medium ** Changed in: python-apt (Ubuntu) Importance: Medium => Critical ** Changed in: python-apt (Ubuntu) Importance: Critical => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscri

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-07-08 Thread Peter Sabaini
clarification: breaking regex parsing at /usr/lib/python3/dist- packages/aptsources/sourceslist.py that is -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplic

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2019-07-08 Thread Peter Sabaini
We're seeing this in the context of a charm where add-apt-repository is called periodically. We ended up with a sources.list file weighing in at 2.6Mb, which created problems for the regex engine there. In light of this can I ask to reconsider the "low" importance of this bug? FTR. this is Bionic,

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-22 Thread Julian Andres Klode
This might be enough to fix it - I just compare the values against each other rather than doing 4 explicit cases. I call bool() on them first before comparing them as we want a boolean comparison here, and that should work even if you pass None or "" or whatever I guess. diff --git a/aptsources/so

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-22 Thread Julian Andres Klode
Analysis *before* situation: The loop after the __find call did not really match the __find call before - it was looking only for non- disabled sources, but then had an if case for disabled ones to enable them if the components match - which was never reached. Now, I think the patch is slightly w

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-22 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines To manage notifications about this bug go to: htt

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-22 Thread Brian Murray
Julian - Do you have an opinion on this change to python-apt to handle adding disabled sources? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate comment

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-22 Thread Brian Murray
Here's a patch to software-properties. ** Patch added: "bug-1311056.patch" https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1311056/+attachment/5026186/+files/bug-1311056.patch ** Changed in: software-properties (Ubuntu) Status: Confirmed => Triaged -- You received

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-22 Thread Brian Murray
And here's the patch for python-apt. ** Patch added: "bug-1311056-apt.patch" https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1311056/+attachment/5026187/+files/bug-1311056-apt.patch ** Also affects: python-apt (Ubuntu) Importance: Undecided Status: New ** Changed

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-22 Thread Brian Murray
It's actually python3-apt's sourceslist.py which does the duplicate checking and software properties is passing a type, '# deb-src', which I think is an abuse of what python-apt expects. I believe it'd want a 'deb' or 'deb-src' type. So we end up in this strange situation where are not searching fo

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2017-12-21 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: software-properties (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2014-04-28 Thread Sebastien Bacher
** Changed in: software-properties (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source l

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2014-04-22 Thread Jan Groenewald
Of which bug? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disabled source lines To manage notifications about this bug go to: https://bu

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2014-04-22 Thread Brian Murray
I think this is a duplicate. ** Package changed: ubuntu => software-properties (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1311056 Title: apt-add-repository adds duplicate commented/disa

[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines

2014-04-22 Thread Ubuntu Foundations Team Bug Bot
Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people