Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Miquel Raynal
Hi Michael, mich...@amarulasolutions.com wrote on Tue, 1 Oct 2024 15:02:56 +0200: > Hi > > On Tue, Oct 1, 2024 at 12:01 PM Miquel Raynal > wrote: > > > > Hi Michael, > > > > > > Ported the patch from patchset > > > > > > > > "[PATCH 05/26] clk: imx8mm: Mark IMX8MM_SYS_PLL2 and

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Miquel Raynal
Hi Heiko, > >> I see with your patch the clock names, so fine... and see [1] > >> > >> Hmm... I am on imx8mp, and I think the changes the patchset do in > >> > >> "clk: imx8mn: Prevent clock critical path from disabling during reparent > >> and set_rate" > >> > >> are in clk-imx8mp already ... >

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Michael Nazzareno Trimarchi
Hi On Tue, Oct 1, 2024 at 12:01 PM Miquel Raynal wrote: > > Hi Michael, > > > > Ported the patch from patchset > > > > > > "[PATCH 05/26] clk: imx8mm: Mark IMX8MM_SYS_PLL2 and IMX8MM_SYS_PLL3 > > > as enabled" > > > > > > to imx8mp [2] and fec ethernet works again f

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Miquel Raynal
Hi Michael, mich...@amarulasolutions.com wrote on Tue, 1 Oct 2024 10:33:56 +0200: > Hi Miguel > > On Tue, Oct 1, 2024 at 10:29 AM Miquel Raynal > wrote: > > > > Hi Heiko, > > > > > > > >>> Hmm.. unfortunately ... I had applied your 2 clock patches, which > > > >>> fixed a problem with enabli

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Heiko Schocher
Hello Miquel, On 01.10.24 10:50, Miquel Raynal wrote: Hi Michael, mich...@amarulasolutions.com wrote on Tue, 1 Oct 2024 10:33:56 +0200: Hi Miguel On Tue, Oct 1, 2024 at 10:29 AM Miquel Raynal wrote: Hi Heiko, Hmm.. unfortunately ... I had applied your 2 clock patches, which fixed a p

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Miquel Raynal
Hi Michael, > > Ported the patch from patchset > > > > "[PATCH 05/26] clk: imx8mm: Mark IMX8MM_SYS_PLL2 and IMX8MM_SYS_PLL3 > > as enabled" > > > > to imx8mp [2] and fec ethernet works again for me on imx8mp! > > > > Could you add this if you post a v2 ?

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Heiko Schocher
Hello Miquel, On 01.10.24 10:29, Miquel Raynal wrote: Hi Heiko, Hmm.. unfortunately ... I had applied your 2 clock patches, which fixed a problem with enabling parent clocks ... but they broke booting on a carrier which has fec ethernet! After "Net: " output the board hang... I reverted your

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Miquel Raynal
Hi Heiko, h...@denx.de wrote on Tue, 1 Oct 2024 10:57:27 +0200: > Hello Miquel, > > On 01.10.24 10:50, Miquel Raynal wrote: > > Hi Michael, > > > > mich...@amarulasolutions.com wrote on Tue, 1 Oct 2024 10:33:56 +0200: > > > >> Hi Miguel > >> > >> On Tue, Oct 1, 2024 at 10:29 AM Miquel Raynal

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Miquel Raynal
Hi Heiko, > >>> Hmm.. unfortunately ... I had applied your 2 clock patches, which > >>> fixed a problem with enabling parent clocks ... but they broke booting > >>> on a carrier which has fec ethernet! After "Net: " output the board > >>> hang... > >>> > >>> I reverted your 2 clock patches and i

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Michael Nazzareno Trimarchi
Hi all On Tue, Oct 1, 2024 at 10:59 AM Heiko Schocher wrote: > > Hello Miquel, > > On 01.10.24 10:50, Miquel Raynal wrote: > > Hi Michael, > > > > mich...@amarulasolutions.com wrote on Tue, 1 Oct 2024 10:33:56 +0200: > > > >> Hi Miguel > >> > >> On Tue, Oct 1, 2024 at 10:29 AM Miquel Raynal > >

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Michael Nazzareno Trimarchi
Hi Miguel On Tue, Oct 1, 2024 at 10:29 AM Miquel Raynal wrote: > > Hi Heiko, > > > > >>> Hmm.. unfortunately ... I had applied your 2 clock patches, which > > >>> fixed a problem with enabling parent clocks ... but they broke booting > > >>> on a carrier which has fec ethernet! After "Net: " outp

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-30 Thread Heiko Schocher
Hello Michael, On 01.10.24 07:14, Heiko Schocher wrote: Hi Micahel, On 01.10.24 07:01, Michael Nazzareno Trimarchi wrote: Hi Heko On Tue, Oct 1, 2024 at 6:23 AM Heiko Schocher wrote: Hi Dario, On 30.09.24 15:20, Dario Binacchi wrote: Hello Heiko, On Tue, Sep 24, 2024 at 11:07 AM Heiko S

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-30 Thread Heiko Schocher
Hi Micahel, On 01.10.24 07:01, Michael Nazzareno Trimarchi wrote: Hi Heko On Tue, Oct 1, 2024 at 6:23 AM Heiko Schocher wrote: Hi Dario, On 30.09.24 15:20, Dario Binacchi wrote: Hello Heiko, On Tue, Sep 24, 2024 at 11:07 AM Heiko Schocher wrote: Hello Dario, On 13.09.24 11:55, Dario B

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-30 Thread Michael Nazzareno Trimarchi
Hi Heko On Tue, Oct 1, 2024 at 6:23 AM Heiko Schocher wrote: > > Hi Dario, > > On 30.09.24 15:20, Dario Binacchi wrote: > > Hello Heiko, > > > > On Tue, Sep 24, 2024 at 11:07 AM Heiko Schocher wrote: > >> > >> Hello Dario, > >> > >> On 13.09.24 11:55, Dario Binacchi wrote: > >>> From: Michael Tr

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-30 Thread Heiko Schocher
Hi Dario, On 30.09.24 15:20, Dario Binacchi wrote: Hello Heiko, On Tue, Sep 24, 2024 at 11:07 AM Heiko Schocher wrote: Hello Dario, On 13.09.24 11:55, Dario Binacchi wrote: From: Michael Trimarchi Add iMX8 block ctrl driver for displaymix on iMX8MM/iMX8MN and mediamix on iMX8MP. To supp

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-30 Thread Dario Binacchi
Hello Heiko, On Tue, Sep 24, 2024 at 11:07 AM Heiko Schocher wrote: > > Hello Dario, > > On 13.09.24 11:55, Dario Binacchi wrote: > > From: Michael Trimarchi > > > > Add iMX8 block ctrl driver for displaymix on iMX8MM/iMX8MN and > > mediamix on iMX8MP. > > > > To support blk ctrl driver, the pow

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-24 Thread Heiko Schocher
Hello Dario, On 13.09.24 11:55, Dario Binacchi wrote: From: Michael Trimarchi Add iMX8 block ctrl driver for displaymix on iMX8MM/iMX8MN and mediamix on iMX8MP. To support blk ctrl driver, the power domain driver on iMX8M needs update to add relevant PGC domains Signed-off-by: Ye Li Signed-

[PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-13 Thread Dario Binacchi
From: Michael Trimarchi Add iMX8 block ctrl driver for displaymix on iMX8MM/iMX8MN and mediamix on iMX8MP. To support blk ctrl driver, the power domain driver on iMX8M needs update to add relevant PGC domains Signed-off-by: Ye Li Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi