Re: [Tutor] Review and criticism of python project

2008-01-07 Thread Tiger12506
> Tiger12506 wrote: > >> Ouch. Usually in OOP, one never puts any user interaction into a class. > > That seems a bit strongly put to me. Generally user interaction should be > separated from functional classes but you might have a class to help with > command line interaction (e.g. the cmd module

Re: [Tutor] Review and criticism of python project

2008-01-04 Thread GTXY20
thanks for the feedback - i will go through your comments line by line adjust and test and will re-post when complete. GTXY20 On Jan 4, 2008 9:29 PM, Kent Johnson <[EMAIL PROTECTED]> wrote: > Tiger12506 wrote: > > > Ouch. Usually in OOP, one never puts any user interaction into a class. > > That

Re: [Tutor] Review and criticism of python project

2008-01-04 Thread Kent Johnson
Tiger12506 wrote: > Ouch. Usually in OOP, one never puts any user interaction into a class. That seems a bit strongly put to me. Generally user interaction should be separated from functional classes but you might have a class to help with command line interaction (e.g. the cmd module in the s

Re: [Tutor] Review and criticism of python project

2008-01-04 Thread Tiger12506
Cool! Code! (gullom voice - we must look at code, yesss) > Hi there. > > What this section area does is takes a data file that is comma separated > and > imports - there is a unique ID in the first field and a code in the second > field that corresponds to a certain section of information. Wh

Re: [Tutor] Review and criticism of python project

2008-01-04 Thread Alan Gauld
"GTXY20" <[EMAIL PROTECTED]> wrote > Sorry for the lengthly code response - all commenst are > appreciated - as > mentioned I am quite new with Python - it is doing what I need it to > do but > I think that it is a mess and needs to be cleaned up a little. I've only skimmed it very quickly and

Re: [Tutor] Review and criticism of python project

2008-01-04 Thread GTXY20
Hi there. What this section area does is takes a data file that is comma separated and imports - there is a unique ID in the first field and a code in the second field that corresponds to a certain section of information. What I need from this is for the process to role up against unique ID all se

Re: [Tutor] Review and criticism of python project

2008-01-04 Thread bob gailer
GTXY20 wrote: > > There are no errors per se - the script is doing what it needs to I > guess I just want to check it for compliance - for some reason I think > itis a mess and should be much cleaner. > > I am only concerned with one particular area of the complete project - > it is 229 line

Re: [Tutor] Review and criticism of python project

2008-01-04 Thread GTXY20
There are no errors per se - the script is doing what it needs to I guess I just want to check it for compliance - for some reason I think itis a mess and should be much cleaner. I am only concerned with one particular area of the complete project - it is 229 lines in total - would this be too muc

Re: [Tutor] Review and criticism of python project

2008-01-03 Thread bob gailer
GTXY20 wrote: > > Hello all, > > Is there a forum or group where I can upload my python project for review? Others on this list can guide you to web sites for uploading code. If the program is relatively small you can just email it to this list as body text. How small? For me I'd rather wade thru

Re: [Tutor] Review and criticism of python project

2008-01-03 Thread bhaaluu
If you have a web page, you can upload the code to your web page, then post here with a link to the code and a request for reviews. That's one way to do it. -- b h a a l u u at g m a i l dot c o m On Jan 3, 2008 5:00 PM, GTXY20 <[EMAIL PROTECTED]> wrote: > > Hello all, > > Is there a forum or gro