Re: [Tutor] My horrible looking program needs improvement.

2008-11-25 Thread Peter van der Does
On Tue, 25 Nov 2008 13:04:35 +0100 spir <[EMAIL PROTECTED]> wrote: > Hello Peter, > > Your program's structure is rather well designed... with words and > whitespace. You just need to export each consistent part of your > main() into a specialised section: module, object, function. I would > sugg

Re: [Tutor] My horrible looking program needs improvement.

2008-11-25 Thread Kent Johnson
On Mon, Nov 24, 2008 at 2:21 PM, Peter van der Does <[EMAIL PROTECTED]> wrote: > On Mon, 24 Nov 2008 11:00:59 -0500 > Peter van der Does <[EMAIL PROTECTED]> wrote: > >> I wrote my 1st Python program and it works as I want it to work but >> ,IMHO, it looks horrible. > OK, I put the code here: > > h

Re: [Tutor] My horrible looking program needs improvement.

2008-11-24 Thread Peter van der Does
On Mon, 24 Nov 2008 11:00:59 -0500 Peter van der Does <[EMAIL PROTECTED]> wrote: > I wrote my 1st Python program and it works as I want it to work but > ,IMHO, it looks horrible. > > As to what my program does: > It downloads a file from the web, downloads .htaccess and Apache log > file from a F

Re: [Tutor] My horrible looking program needs improvement.

2008-11-24 Thread Kent Johnson
On Mon, Nov 24, 2008 at 11:00 AM, Peter van der Does <[EMAIL PROTECTED]> wrote: > I wrote my 1st Python program and it works as I want it to work but > ,IMHO, it looks horrible. > > Is this the place where somebody could go over my program and give > some pointers on how to improve the structure or

Re: [Tutor] My horrible looking program needs improvement.

2008-11-24 Thread Alan Gauld
Everything is in main(), I would like to use functions but ran into problems with the scope of my variables. Did your functions have parameters? Thats usually how to deal with passing names between scopes. Is this the place where somebody could go over my program Yes. If this is the place,

Re: [Tutor] My horrible looking program needs improvement.

2008-11-24 Thread W W
On Mon, Nov 24, 2008 at 10:00 AM, Peter van der Does <[EMAIL PROTECTED] > wrote: > I wrote my 1st Python program and it works as I want it to work but > ,IMHO, it looks horrible. Nothing to be ashamed of, unless you don't mind it looking horrible. The fact that you want a clean program is a good

[Tutor] My horrible looking program needs improvement.

2008-11-24 Thread Peter van der Does
I wrote my 1st Python program and it works as I want it to work but ,IMHO, it looks horrible. As to what my program does: It downloads a file from the web, downloads .htaccess and Apache log file from a FTP site, using the IP's from the Apache log it checks if the IP exists in the web-file, if it