Thanks; applied!
On Mon, Jan 5, 2015 at 1:08 PM, Justin Findlay wrote:
> On 01/05/2015 09:26 AM, Gisle Vanem wrote:
>> Gisle Vanem wrote:
>>
>>> I only get 2 errors in that script. The others like:
>>>self.assertTrue(out_verif.endswith("Configuration was valid\n"))
>>>
>>> needs another patch
Nick Mathewson wrote:
If possible, it would be handy to have a patch as an attachment, or a
complete diff, or something I could apply?
Attached.
--
--gv
diff --git a/src/test/test_cmdline_args.py b/src/test/test_cmdline_args.py
index 55d1cdb..c8e68e8 100755
--- a/src/test/test_cmdline_args.p
On Mon, Jan 5, 2015 at 1:08 PM, Justin Findlay wrote:
> On 01/05/2015 09:26 AM, Gisle Vanem wrote:
>> Gisle Vanem wrote:
>>
>>> I only get 2 errors in that script. The others like:
>>>self.assertTrue(out_verif.endswith("Configuration was valid\n"))
>>>
>>> needs another patch which is beyond m
On 01/05/2015 09:26 AM, Gisle Vanem wrote:
> Gisle Vanem wrote:
>
>> I only get 2 errors in that script. The others like:
>>self.assertTrue(out_verif.endswith("Configuration was valid\n"))
>>
>> needs another patch which is beyond my Python knowledge.
>
> I think it's fine now with this chang
Gisle Vanem wrote:
I only get 2 errors in that script. The others like:
self.assertTrue(out_verif.endswith("Configuration was valid\n"))
needs another patch which is beyond my Python knowledge.
I think it's fine now with this change:
@@ -57,14 +57,14 @@
raise UnexpectedFailure()
Nice catch Gisle!
This is actually the first I've heard about test_cmdline_args.py.
Interesting. These would be a good fit for our stem.process integ
tests...
https://gitweb.torproject.org/stem.git/tree/test/integ/process.py
I'd be up for adding them, then tor could use them to exercise itself
There are some problems with 'run_tor()' and line-endings.
It doesn't forsee any '\r\n' from 'Popen()' and since 'lines()'
only splits on '\n', most of the tests fails.
With this little patch:
@@ -64,7 +64,7 @@
yield fp[i:i+4]
def lines(s):
-out = s.split("\n")
+out = s.splitl
