Re: [tor-dev] common/aes.c troubles

2011-12-18 Thread Nick Mathewson
On Sun, Dec 18, 2011 at 7:46 AM, Gisle Vanem wrote: > "Nick Mathewson" wrote: > >> I'd say "not so good" if it only applies to MSVC builds. > > > I applies to all Win builds. Are you not getting any warnings > and errors when compiling aes.c? I was referring to your idea of orconfig.h changes.

Re: [tor-dev] common/aes.c troubles

2011-12-18 Thread Gisle Vanem
"Nick Mathewson" wrote: I'd say "not so good" if it only applies to MSVC builds. I applies to all Win builds. Are you not getting any warnings and errors when compiling aes.c? Of course, if we patched the autoconf script so that it defined the macro when building on windows with mingw, that

Re: [tor-dev] common/aes.c troubles

2011-12-17 Thread Nick Mathewson
On Wed, Dec 14, 2011 at 6:28 AM, Gisle Vanem wrote: > How about it? I'd say "not so good" if it only applies to MSVC builds. The orconfig.h files is supposed to correspond exactly to the one that would ordinarily be generated by the autoconf script for on other platforms. Of course, if we patc

[tor-dev] common/aes.c troubles

2011-12-14 Thread Gisle Vanem
In common/aes.c: #include "orconfig.h" #include ... #include .. #include "compat.h" By default is included in when WIN32_LEAN_AND_MEAN is not defined. But this is defined too late; in compat.h. So when in OpenSSL pulls in and gets included in compat.h, I'm getting lots of warnings and red