Re: [tor-dev] Unit testing blog posts

2012-02-18 Thread Esteban Manchado Velázquez
Hey Damian! Wasn't sure if follow up privately or to the list, sending this to the list for now. On Thu, 16 Feb 2012 22:09:44 +0100, Damian Johnson wrote: Nice posts and thanks for improving the tor tests! I'm not entirely in agreement with the last point (about tests covering all cases

Re: [tor-dev] Unit testing blog posts

2012-02-16 Thread Damian Johnson
Nice posts and thanks for improving the tor tests! I'm not entirely in agreement with the last point (about tests covering all cases). If the test space is decently small then exercising everything can better ensure that you don't violate a set of invariants. For example, one of stem's unit tests a

Re: [tor-dev] Unit testing blog posts

2012-02-16 Thread Tim Wilde
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/15/2012 6:07 PM, Esteban Manchado Velázquez wrote: > I ended up publishing it in two parts :-) Here are the URLs: > > > http://hcoder.org/2012/02/13/unit-testing-advice-for-seasoned-hackers-12/ > > > http://hcoder.org/2012/02/15/unit-testing-a

[tor-dev] Unit testing blog posts

2012-02-15 Thread Esteban Manchado Velázquez
I ended up publishing it in two parts :-) Here are the URLs: http://hcoder.org/2012/02/13/unit-testing-advice-for-seasoned-hackers-12/ http://hcoder.org/2012/02/15/unit-testing-advice-for-seasoned-hackers-22/ Now I'll have a look at the coverage and see what I can do for the unit tests b