Re: [tor-dev] Trivial patch: avoid redundant calls to ENGINE_register_all_complete

2013-12-19 Thread coderman
On Wed, Dec 18, 2013 at 7:05 PM, Nick Mathewson wrote: > ... Is there any actual harm in the redundant invocation of > ENGINE_register_all_complete(), or is this about cleanliness/saving > cycles/something else? > > Assuming it's not actually harmful, I'd prefer to leave the call in, > with a comm

Re: [tor-dev] Trivial patch: avoid redundant calls to ENGINE_register_all_complete

2013-12-18 Thread Nick Mathewson
On Wed, Dec 18, 2013 at 12:57 PM, coderman wrote: > hello all, Nick, > > per the other thread in tor-talk about RDRAND, this is the minor fix > for OpenSSL 1.0.1+ mentioned. > > i don't know that this is useful, and i am still giving the engine > code a thorough review per Nick's other feedback: "

Re: [tor-dev] Trivial patch: avoid redundant calls to ENGINE_register_all_complete

2013-12-18 Thread coderman
i was able to confirm the expected behavior using the BADRAND engine attached to same ticket: https://trac.torproject.org/projects/tor/ticket/10402 and also here (do trac tickets ever go away / get deleted?): https://peertech.org/dist/openssl-1.0.1e-badrand-test.patch currently Tor on 1.0.1+

[tor-dev] Trivial patch: avoid redundant calls to ENGINE_register_all_complete

2013-12-18 Thread coderman
hello all, Nick, per the other thread in tor-talk about RDRAND, this is the minor fix for OpenSSL 1.0.1+ mentioned. i don't know that this is useful, and i am still giving the engine code a thorough review per Nick's other feedback: "Above all, do not assume that you understand how OpenSSL works