> Maybe you could comment on the comments, or at least keep an eye on it
Replied. I clicked watch but I'm not familiar with how github code
reviews work so I might not notice updates.
> Also, I don't suppose you know how to comment on the file, instead of on the
> diff?
I don't. Personally I do
On 7/12/12 12:15 PM, Damian Johnson wrote:
Also, you aren't checking that all of the descriptors are of the same
type. If you get a list with both server descriptors and extrainfo
descriptors then I'm not sure what this function will do, but it's
probably not what the user wants. Please include
Hi Erik. In addition to Norman's feedback...
> def descriptor_csv_exp(descr, head=True, incl_fields=[], excl_fields=[]):
It's redundant to call this descriptor_csv_exp() since it's in
'stem.descriptor.*'. Lets just call it something simple like
export_csv(). Also, I still think that we should com
Hi Damian,
Here is a first draft for the tor export module we have been discussing. I
have attached the file as we were having some git issues and I am in a bit
of a rush right now. We have been developing the file at
stem/descriptors/export.py. Any suggestions or comments would be
appreciated
