Re: [tor-dev] Stem code review 2012-12-21

2012-12-22 Thread Damian Johnson
Hi Sean, thanks for the code review! > Would GETINFO/GETCONF cache hit logging[1] benefit from log_once? Or even > something between log and log_once (e.g. rate_limited_log)? Interesting thought, but I don't think so. When I look for cache hits it's usually to answer the question of 'did doing

[tor-dev] Stem code review 2012-12-21

2012-12-22 Thread Sean Robinson
Stem devs, This is a review of Stem commits from 2012-12-11 through 2012-12-21. Damian, you are very good at documentation, concise and informative. I tend to hit one or the other, but not both. I recognize when someone gets the right mix. Good work. I, too, have found logging.basicConfig[0]