Re: [tor-dev] Stem code review 2012-12-10

2012-12-14 Thread Damian Johnson
Hi Sean, thanks for the code review! > As to re-attaching event listeners[1], I agree that putting a specialized > hook into BaseController.msg seems bad. I have an alternate idea[2] that > puts the re-attachment in an authenticate method. I am not proposing this > as the solution, but I hope th

[tor-dev] Stem code review 2012-12-10

2012-12-14 Thread Sean Robinson
Stem devs, This is a review of recent commits to Stem. It begins where my last review ended[0] and finishes at the "Adding a close_stream..." merge. The pydoc changes to Controller.extend_circuit are good additions. I do not understand much of the context for changes regarding network status do