Re: [tor-dev] Stem code review 2012-12-04

2012-12-08 Thread Damian Johnson
> I must not be reasoning about Event._parse_standard_attr() correctly. I > think it is already looking for _QUOTED positional args, but is working at > it backwards from _KEYWORD_ARGS parsing. Right. The thing that I'm talking about is *new* quoted arguments (ie, things not presently in the spec

Re: [tor-dev] Stem code review 2012-12-04

2012-12-08 Thread Sean Robinson
On Fri, Dec 7, 2012 at 8:01 PM, Damian Johnson wrote: > > The quoted key/value mapping is more readable, now. Good work. Why not > look for quoted positional args before non-quoted positional args? Why not > do just like kwarg handling? > MY_EVENT "arg1 arg2" > > ... where the spec says we rea

Re: [tor-dev] Stem code review 2012-12-04

2012-12-07 Thread Damian Johnson
Hi Sean. Thanks for code reviewing my recent commits! > 1) I do not like the new _get_event() with assert_class and assert_content. > There are transformations and tests and returned values all within what is a > mock object builder, meaning it works via side-effect. This could be > surprisin

[tor-dev] Stem code review 2012-12-04

2012-12-07 Thread Sean Robinson
Stem devs, I did a code review of recent Stem commits ("Tor event handling" merge (commit 42872dd08e81d6b3) through "Checking for None by identity" (commit 69f72efc9367092c)). My comments and questions follow. I will skip my own contributions (they were great 8-) in that range, as I am biased.