Re: [tor-dev] Stegotorus Challenge - Inheriting from FileStegMod

2014-04-07 Thread vmon
Hey Noah, Thanks a lot for the patch. You are doing a great job. I commited your changes here: https://github.com/zackw/stegotorus/commit/a92f977259dd3aaabe9f5812f79bbe73456ecdf6#diff-07d0e8b69b9ddf7f371fd93a4204acea Please pull the branch f--file-stegize-swf-js-pdf and continue work there. Few

Re: [tor-dev] Stegotorus Challenge - Inheriting from FileStegMod

2014-04-06 Thread vmon
Hey Noah, > size_t tmp_len = cover_len * 32; //assert here to prevent overflow This is probably prevented somewhere else, but it is always good to harden the code. > /*if (inf_len < 0 || > out_sz < inf_len - SWF_SAVE_HEADER_LEN - SWF_SAVE_FOOTER_LEN) { > fprintf(stderr, "inf_len = %d\

Re: [tor-dev] Stegotorus Challenge - Inheriting from FileStegMod

2014-04-04 Thread vmon
Hey Noah, For committing: I think Zack needs to give you write access. Please send your github id to Zack (za...@cmu.edu) and cc me. Once that is done, please branch out of tor-improve and commit. If it takes Zack long to give you permission, you can just fork Zackw/stegotorus of course. Just ple