On 05/08/15 15:21, meejah wrote:
>
> BTW, where is this code coming from? I looked on github but only see the
> proposal stuf (which is using Tornado not Cyclone, so I'm guessing
> that's not the right stuff?)
>
Hi!
Thank you both Damian and meejah for your comments! I'll review your
feedback a
> On 6 Aug 2015, at 02:53 , Damian Johnson wrote:
>
>
> client/templates/index.html
>
>
> 10 href="http://fonts.googleapis.com/css?family=Open+Sans:400italic,600italic,400,
Sorry for the noise, I found the code ("develop" branch of
https://github.com/leivaburto/rwsd) and add a couple more comments:
1. The "WEBSOCKETS" global seems like it wants to be a class instead:
you've basically got a bunch of static functions (add_websocket, etc)
that manipulate a global vari
BTW, where is this code coming from? I looked on github but only see the
proposal stuf (which is using Tornado not Cyclone, so I'm guessing
that's not the right stuff?)
___
tor-dev mailing list
tor-dev@lists.torproject.org
https://lists.torproject.org/cg
>> def get_websockets(ws_type = None):
>> websocket = WEBSOCKETS.get(ws_type, [])
>> return websocket if websocket else None
>
> How about just:
>
> def get_websockets(ws_type=None):
> return WEBSOCKETS.get(ws_type, None)
Thanks meejah for the additional feedback! For this la
Damian Johnson writes:
> Very minor thing, but little odd using dict() that way.
Personally, I don't find it that odd ;) and prefer it since braces can
define sets or dicts in Python, and using dict(...) makes it a little
more explicit.
BTW, your counter-example is a syntax error; you need to q
Hi Cristobal, again apologies for the delay in getting you feedback. Just gave
RWSD a whirl and worked great - nice work!
>From a UI perspective only feedback on what we have so far is...
* Both graphs just have the title of 'Graph component'. Better would be to
say if it's inboud or outbou
