Re: [tor-dev] Proc Unit Testing & Next Project

2012-06-27 Thread Damian Johnson
> After talking about it with Professor Danner, we would like to stick > with the Tor Descriptors prject rather than work on Onionoo. Sounds good. > Professor Danner brought up that if this project isn't maintained, our > work could be fruitless Actually, *my* interest in the Onionoo project is

Re: [tor-dev] Proc Unit Testing & Next Project

2012-06-27 Thread Erik I Islo
Damian, After talking about it with Professor Danner, we would like to stick with the Tor Descriptors prject rather than work on Onionoo. Professor Danner brought up that if this project isn't maintained, our work could be fruitless, and at this point we would prefer to stick with Python. We would

Re: [tor-dev] Proc Unit Testing & Next Project

2012-06-26 Thread Erik I Islo
Hi Damian, > In reading the following code I suspect that this could be clearer if it accepted a single argument that was the dict of 'argument => return value'. All set -- mock_fn() now takes a dictionary rather than two lists as an argument. The docstring suggestions have also been implemente

Re: [tor-dev] Proc Unit Testing & Next Project

2012-06-26 Thread Damian Johnson
Hi Erik, hi Megan. > Megan and I have finished a first run at writing unit tests for the proc > utilities in stem. Looks great! I only got down to 'test_get_memory_usage()' before needing to run to catch the bus but the tests that I've seen so far look good. The mocking though confused me for a

[tor-dev] Proc Unit Testing & Next Project

2012-06-25 Thread Erik I Islo
Hi Damian, Megan and I have finished a first run at writing unit tests for the proc utilities in stem. The code may be found on Megan's Github at: https://github.com/meganchang/Stem/blob/proc-tests/test/unit/util/proc.py. Until we hear back on a code review, we'll move on to the integration tests