Re: [tor-dev] Patch to remove goto from sandbox.c

2014-03-01 Thread Hartmut Prochaska
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 Hi, > See , Chapter 7, > “Centralized exiting of functions” for a rationale. I saw some functions where the idea above seems fitting. But there had also been some code parts, like this from

Re: [tor-dev] Patch to remove goto from sandbox.c

2014-03-01 Thread Lunar
Hartmut Prochaska: > I changed a function in sandbox.c to not use a goto statement. I didn't > understood what use it had. Attached the patch file. See , Chapter 7, “Centralized exiting of functions” for a rationale. -- Lunar

[tor-dev] Patch to remove goto from sandbox.c

2014-03-01 Thread Hartmut Prochaska
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 Hi, I changed a function in sandbox.c to not use a goto statement. I didn't understood what use it had. Attached the patch file. I did the usual tests and didn't found any error at first and second glance. Please consider to test it yourself and