Re: [tor-dev] Erebus Code Review

2015-09-08 Thread Cristobal
Hi Damian, thanks for your feedback! I'm replying a few things inline. On 05/09/15 17:02, Damian Johnson wrote: > -- > > 155 def _register_event(self, event): > 156 output = { 'message': '', 'type': ''} > 157

[tor-dev] Erebus Code Review

2015-09-05 Thread Damian Johnson
Hi Cristobal, just took a peek at Erebus and looks good! There's some low hanging fruit for improvement (unused functions and such) but generally looks good. Cheers! -Damian == erebus/server/handlers/log.py ==