Re: [tor-dev] Compile warns

2019-09-12 Thread Nick Mathewson
On Thu, Sep 12, 2019 at 5:15 AM grarpamp wrote: > > On 9/10/19, Nick Mathewson wrote: > > https://trac.torproject.org/projects/tor/ticket/31687 > > needs testing; please let me know if it works for you. > > Works. The second hunk for fp.c is below. Okay. I've added a second branch to the ticket,

Re: [tor-dev] Compile warns

2019-09-12 Thread grarpamp
On 9/10/19, Nick Mathewson wrote: > https://trac.torproject.org/projects/tor/ticket/31687 > needs testing; please let me know if it works for you. Works. The second hunk for fp.c is below. > Is it possible that > a new compiler version or new headers in FreeBSD is what has made them > start appe

Re: [tor-dev] Compile warns

2019-09-10 Thread Nick Mathewson
I've got a possible fix for this at https://trac.torproject.org/projects/tor/ticket/31687 , but it needs testing; please let me know if it works for you. As near as I can tell, this code has been unchanged for a while, so I'm surprised if these warnings are new in 0.4.1. Is it possible that a new

Re: [tor-dev] Compile warns

2019-09-06 Thread grarpamp
On 9/6/19, Nick Mathewson wrote: > What version of Tor? Oops, here it is: 0.4.1.5 ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev

Re: [tor-dev] Compile warns

2019-09-06 Thread Nick Mathewson
On Fri, Sep 6, 2019 at 4:51 AM grarpamp wrote: > > freebsd 12 x64 gcc 8.3.0 > > src/core/or/connection_edge.c:2563:5: warning: potential null pointer > dereference [-Wnull-dereference] > src/lib/math/fp.c:106:16: warning: conversion from 'double' to 'float' > may change value [-Wfloat-conversion]

[tor-dev] Compile warns

2019-09-06 Thread grarpamp
freebsd 12 x64 gcc 8.3.0 src/core/or/connection_edge.c:2563:5: warning: potential null pointer dereference [-Wnull-dereference] src/lib/math/fp.c:106:16: warning: conversion from 'double' to 'float' may change value [-Wfloat-conversion] src/lib/math/fp.c:111:18: warning: conversion from 'double' t