Re: [tor-dev] Code Review (arm) - Initial commit for the menu code

2011-05-27 Thread Damian Johnson
> Why not “titlewidth = max(map(len, titles)) + 2”? Thanks, Robert. Actually, I've never messed with the map function before - that'll be a nice improvement for several points in the codebase. :) ___ tor-dev mailing list tor-dev@lists.torproject.org http

Re: [tor-dev] Code Review (arm) - Initial commit for the menu code

2011-05-27 Thread Robert Ransom
On Fri, 27 May 2011 13:07:49 -0700 Damian Johnson wrote: > Hi all. Kamran and I are gonna doing code reviews publicly so if > you're interested and spot issues we miss then feel free to chime in. > -Damian > > Change: > https://gitweb.torproject.org/user/krkhan/arm.git/commitdiff/5fd9b5f74a86eb

[tor-dev] Code Review (arm) - Initial commit for the menu code

2011-05-27 Thread Damian Johnson
Hi all. Kamran and I are gonna doing code reviews publicly so if you're interested and spot issues we miss then feel free to chime in. -Damian Change: https://gitweb.torproject.org/user/krkhan/arm.git/commitdiff/5fd9b5f74a86eb7e641366ae1c0a1a47404cf873 > ARM_CONTROLLER = Controller(stdscr, stick