Re: [tor-dev] Chutney code refactoring

On Fri, 15 May 2020 11:20:54 +1000 teor wrote: > You could try deleting functions, and then running tor's > "make test-network-all". If that test still passes, then the code is probably > unused (in practice). > > Chutney's CI does a few more tests for different tor versions, but I'm pretty > su

Re: [tor-dev] Chutney code refactoring

On Thu, 14 May 2020 19:58:45 -0400 Nick Mathewson wrote: > isInExpectedDirInfoDocs looks like it might once have done something useful. My impression is to remove it unless we anticipate needing it in the near future. > configure and restart and wait_for_bootstrap are all in use; they are > inv

Re: [tor-dev] Chutney code refactoring

Hi Caitlin, > On 15 May 2020, at 09:59, Nick Mathewson wrote: > > On Thu, May 14, 2020 at 7:04 PM c wrote: >> >>> On Sat, 18 Apr 2020 11:02:03 + >>> c wrote: >>> >>> I came across Node.specialize() which does not seem to be called >>> elsewhere, and I cannot guess at its purpose. >> >>

Re: [tor-dev] Chutney code refactoring

On Thu, May 14, 2020 at 7:04 PM c wrote: > > On Sat, 18 Apr 2020 11:02:03 + > c wrote: > > > I came across Node.specialize() which does not seem to be called > > elsewhere, and I cannot guess at its purpose. > > I ran vulture (a static analyzer for dead code), trimmed the output to > omit thi

Re: [tor-dev] Chutney code refactoring

On Sat, 18 Apr 2020 11:02:03 + c wrote: > I came across Node.specialize() which does not seem to be called > elsewhere, and I cannot guess at its purpose. I ran vulture (a static analyzer for dead code), trimmed the output to omit things I know were being used (some functions/attributes are

Re: [tor-dev] Chutney code refactoring

On Fri, Apr 17, 2020 at 10:03 PM c wrote: > > On Fri, 17 Apr 2020 18:01:42 -0400 > Nick Mathewson wrote: > > > > Though I think this is likely to be an ongoing change that we see > > over time, since > > Was this sentence supposed to be longer? Yeah, I'm afraid I do that sometimes. I start comp

Re: [tor-dev] Chutney code refactoring

On Fri, 17 Apr 2020 18:01:42 -0400 Nick Mathewson wrote: > If you want to work on this it would be helpful to maybe start by > listing (here or elsewhere) some places where you *don't* feel like > you could (or would want to) write documentation: those would be a > good target for devs who _have_

Re: [tor-dev] Chutney code refactoring

c writes: > I can look into this; personally I have no experience with Python > style-checking or linting tools, but now's a good time as ever for me > to learn what is available and how it would work for Chutney. For style-enforcement, things seem to be converging around "black" in the Python c

Re: [tor-dev] Chutney code refactoring

On Fri, 17 Apr 2020 18:01:42 -0400 Nick Mathewson wrote: > If you want to work on this it would be helpful to maybe start by > listing (here or elsewhere) some places where you *don't* feel like > you could (or would want to) write documentation: those would be a > good target for devs who _have_

Re: [tor-dev] Chutney code refactoring

On Wed, Apr 15, 2020 at 11:45 PM c wrote: Skipping over some design stuff that seems reasonable. [...] > Here is what I have been considering lately, with the code overall. I > hope that laying it out in points will help both myself and others try > to divy up what could be improved about the c

Re: [tor-dev] Chutney code refactoring

On Thu, 16 Apr 2020 20:12:18 +0400 meejah wrote: > As to the specific DictWrapper issue, I also found this confusing. It's > kind of tied into a custom templating system too. I would question > whether this is a good idea; there are many templating systems already > for Python -- what does Chutne

Re: [tor-dev] Chutney code refactoring

Context: I've done a lot of Python development and once upon a time delved into Chutney a little bit. In general I agree that there are some confusing things including inheritance. So, I think giving it some love through refactoring would make it more approachable. As to the specific DictWrapper

[tor-dev] Chutney code refactoring

I was going to mention this on my pull request but I figured it would be much more fitting to have a more-general thread here. In the PR I mentioned how I believe that, if it quacks like a dict, it should be implemented as a dict. That way we (hopeful

Re: [tor-dev] Chutney tests fail for tor/maint-0.3.5 (bug #33677)

(Forgot to hit "reply all" in my mail client) On Mon, 30 Mar 2020 13:22:21 +1000 teor wrote: > This ticket is a cleanup ticket, after some other changes have been made. > I've edited the ticket description to make that clearer. Understood, thank you for clarifying. > Check for onion service

Re: [tor-dev] Chutney tests fail for tor/maint-0.3.5 (bug #33677)

Hi Caitlin, > On 1 Apr 2020, at 18:58, c wrote: > > On Mon, 30 Mar 2020 13:22:21 +1000 > teor wrote: > >> Check for onion service descriptor uploads: >> https://trac.torproject.org/projects/tor/ticket/33609 >> >> Someone else is working on the microdescriptor changes at the moment. >> >> Wou

Re: [tor-dev] Chutney tests fail for tor/maint-0.3.5 (bug #33677)

Hi, > On 28 Mar 2020, at 21:42, c wrote: > > For the Outreachy.org internship project I decided to take on bug > #33677 [1]. Thanks for applying for Outreachy with us. > I followed steps to run `make test-network-all` both on tor master and > maint-0.3.5 branches, using Chutney master branch.

[tor-dev] Chutney tests fail for tor/maint-0.3.5 (bug #33677)

Hi, For the Outreachy.org internship project I decided to take on bug #33677 [1]. I followed steps to run `make test-network-all` both on tor master and maint-0.3.5 branches, using Chutney master branch. I tested before and after tweaking value of HS_WAIT_FOR_UNCHECKED_DIR_INFO just to ensure my

[tor-dev] Chutney Default: DNS or Offline?

Dear chutney users, Do you use DNS with chutney? (Chutney uses IP addresses by default.) Chutney has never worked offline, because Tor Exits check DNS before publishing their exit policy. And if DNS fails while a test is being run, chutney fails. (See Tor bug #21900.) We can make chutney work of

[tor-dev] Chutney (was Re: Performance testing using chutney)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Well, you could test my latest branches for #14175: > > https://trac.torproject.org/projects/tor/ticket/14175#comment:8 > > There's a branch which modifies src/test/test-network.sh in tor, > and another with the performance measurement code in chut

Re: [tor-dev] Chutney couldn't start Tor instances

gain for the help. Hopefully the Chutney devs see this! Relevant: https://xkcd.com/196/ -- Jesse V. On 07/27/2014 04:00 AM, tor-dev-requ...@lists.torproject.org wrote: > Date: Sat, 26 Jul 2014 18:51:44 -0400 > From: Sukhbir Singh > To: tor-dev@lists.torproject.org > Subject: Re: [tor

Re: [tor-dev] Chutney couldn't start Tor instances

Hi, > No log files are generated in /net/nodes/000a, so I don't know what > happened. I don't see any conflicts with ports on localhost as far as I can > see. > Tor version 0.2.4.22 and Python 2.7.5+ are installed. Any ideas? I find it helpful to remove the "--quiet" switch from lib/chutney/TorNe

[tor-dev] Chutney couldn't start Tor instances

Hello everyone, I'm doing some research on Tor and I'm trying to set up a small sample Tor network to play with. I cloned the Chutney repository with /$ git clone https://git.torproject.org/chutney.git/ and then I ran /$ ./chutney configure networks/basic/ which generated the keys for each of th

Re: [tor-dev] Chutney

On Thu, Oct 10, 2013 at 5:01 PM, Charlie Belmer wrote: > Hey everyone, > > I am running some Chutney tests, and I want to go deeper than just running > the bootstrap script and watching logs. Does anyone have advice on how to > get the most out of Chutney? I think the most there is right now is w

[tor-dev] Chutney

Hey everyone, I am running some Chutney tests, and I want to go deeper than just running the bootstrap script and watching logs. Does anyone have advice on how to get the most out of Chutney? Thanks! Charlie ___ tor-dev mailing list tor-dev@lists.torpr