Re: [tor-dev] [Patch] test_util.c with MSVC

2012-04-26 Thread Nick Mathewson
On Thu, Apr 26, 2012 at 4:37 PM, Esteban Manchado Velázquez wrote: > On Thu, 26 Apr 2012 09:09:09 +0200, Gisle Vanem wrote: > >> The src/test/test_util.c doesn't compile with MSVC (CL ver. >> 16.00.30319.01). >> It doesn't like the "#ifdef 0" construct, but the whole chunk should be >> enabled wi

Re: [tor-dev] [Patch] test_util.c with MSVC

2012-04-26 Thread Esteban Manchado Velázquez
On Thu, 26 Apr 2012 09:09:09 +0200, Gisle Vanem wrote: The src/test/test_util.c doesn't compile with MSVC (CL ver. 16.00.30319.01). It doesn't like the "#ifdef 0" construct, but the whole chunk should be enabled with some modifications IMHO. Ugh, sorry about that. I made the changes bl

[tor-dev] [Patch] test_util.c with MSVC

2012-04-26 Thread Gisle Vanem
The src/test/test_util.c doesn't compile with MSVC (CL ver. 16.00.30319.01). It doesn't like the "#ifdef 0" construct, but the whole chunk should be enabled with some modifications IMHO. 'path_is_relative()' doesn't handle the "http:\\dir" case though. Why should it? Besides 'expand_filename()' i

Re: [tor-dev] [Patch] test_util.c

2011-11-11 Thread Nick Mathewson
On Fri, Nov 11, 2011 at 11:46 AM, Gisle Vanem wrote: > Those '{}' constructs are not well liked by MSVC (cl v.16.xx). > An easy fix: Applied; thanks! -- Nick ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cgi-bin/ma

[tor-dev] [Patch] test_util.c

2011-11-11 Thread Gisle Vanem
Those '{}' constructs are not well liked by MSVC (cl v.16.xx). An easy fix: diff --git a/src/test/test_util.c b/src/test/test_util.c index 2146299..64bf52e 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -1597,7 +1597,7 @@ test_util_join_win_cmdline(void *ptr) {"a\\b", "de