On Thu, Apr 7, 2011 at 6:26 PM, Gisle Vanem wrote:
> Another patch for this:
Looks good, except that tmp is a non-const variable and the string is
going to be const. Does the tweaked version I attached work for you?
--
Nick
From 70e02914682eb1959d8b385f76b5acf7486158cc Mon Sep 17 00:00:00 2001
"Nick Mathewson" wrote:
Sounds fine to me. Alternatively, I believe we could just call
GetTempPath(): that's what it's there for.
Agreed. I first thought of using GetTempPath() but that involves another
buffer and checking the ret-val. It's safes though. From:
http://msdn.microsoft.com/en-
On Thu, Apr 7, 2011 at 5:17 PM, Steven J. Murdoch
wrote:
> On Thu, Apr 07, 2011 at 05:10:05PM -0400, Nick Mathewson wrote:
>> On Thu, Apr 7, 2011 at 3:48 PM, Gisle Vanem wrote:
>> > - "c:\\windows\\temp\\tor_test_%d", (int)getpid());
>> > + "%s\\tor_test_%d", getenv("T
On Thu, Apr 07, 2011 at 05:10:05PM -0400, Nick Mathewson wrote:
> On Thu, Apr 7, 2011 at 3:48 PM, Gisle Vanem wrote:
> > - "c:\\windows\\temp\\tor_test_%d", (int)getpid());
> > + "%s\\tor_test_%d", getenv("TEMP"), (int)getpid());
>
> What guarantees that TEMP will alwa
On Thu, Apr 7, 2011 at 3:48 PM, Gisle Vanem wrote:
> I don't think it's a good idea to use hard-coded paths. Even in a
> test source-file. Easy patch:
>
> --- Git-latest\src\test\test.c Wed Mar 30 11:58:28 2011
> +++ src\test\test.c Thu Mar 31 14:06:14 2011
> @@ -86,7 +86,7 @@
> #ifdef MS_W
I don't think it's a good idea to use hard-coded paths. Even in a
test source-file. Easy patch:
--- Git-latest\src\test\test.c Wed Mar 30 11:58:28 2011
+++ src\test\test.c Thu Mar 31 14:06:14 2011
@@ -86,7 +86,7 @@
#ifdef MS_WINDOWS
//
tor_snprintf(temp_dir, sizeof(temp_dir),
-
