On Fri, Jul 17, 2015 at 6:32 AM, Gisle Vanem wrote:
> Nick Mathewson wrote:
>
>> I made the changes conditional on not having GCC, since the GCC syntax
>>
>> will work with older versions of GCC. (Somebody should check whether
>> we care about those versions.)
>
>
Thanks for the info!
> I saw
Nick Mathewson wrote:
> I made the changes conditional on not having GCC, since the GCC syntax
will work with older versions of GCC. (Somebody should check whether
we care about those versions.)
I saw that; from the Changelog:
o Minor features (portability):
- Use C99 variadic macros w
On Tue, May 19, 2015 at 3:20 PM, Gisle Vanem wrote:
> This gcc-centric macro in or/config.c doesn't work well in
> MSVC v16/18:
>
> #define COMPLAIN(args...) \
> STMT_BEGIN log_warn(LD_CONFIG, args); STMT_END
>
> I suggest it should be patched like this:
>
> --- a/config.c 2015-05-06 22:22
Hello Gisle,
I will look into this later this week. Do you use the
workflow in building-tor-msvc.txt to build tor on
Windows?
2015-07-10 14:15, Gisle Vanem rašė:
Ping list?
Gisle Vanem wrote:
This gcc-centric macro in or/config.c doesn't work well in
MSVC v16/18:
#define COMPLAIN(args...) \
Ping list?
Gisle Vanem wrote:
This gcc-centric macro in or/config.c doesn't work well in
MSVC v16/18:
#define COMPLAIN(args...) \
STMT_BEGIN log_warn(LD_CONFIG, args); STMT_END
Even MSVC v19 doesn't have such preprocessor magic. It's
gcc specific and not C99 I guess. Can you please use
'_
This gcc-centric macro in or/config.c doesn't work well in
MSVC v16/18:
#define COMPLAIN(args...) \
STMT_BEGIN log_warn(LD_CONFIG, args); STMT_END
I suggest it should be patched like this:
--- a/config.c 2015-05-06 22:22:09 +
+++ b/config.c 2015-05-06 23:15:57 +
@@ -2571,8 +2571