Re: [tor-dev] #6512 [Stem]: TorExport Module and Unit Testing

2012-08-07 Thread Damian Johnson
Hi Erik. Sorry about pushing the revisions without checking first. I didn't want to distract you and Megan from Onionoo by having a prolonged code review though on reflection it was rude of me to not ask first. Apologies. :( > Looking at coverage the test provides, I was under the impression that

Re: [tor-dev] #6512 [Stem]: TorExport Module and Unit Testing

2012-08-06 Thread Erik I Islo
Hi Damian, Looking at coverage the test provides, I was under the impression that the various cases of include_fields and exclude fields (e.g. if they overlap) should also be tested, but if you find that unnecessary, that would help explain why my unit tests were difficult to follow. In the mocki