Re: [tor-dev] When to exit 0 on error

2017-06-24 Thread f55jwk4f
On Fri, Jun 23, 2017 at 10:29:32AM -0400, Zack Weinberg wrote: > On Fri, Jun 23, 2017 at 9:29 AM, Nick Mathewson wrote: > > On Thu, Jun 22, 2017 at 10:49 PM, wrote: > >> I noticed tor sometimes exits 0 on error > >> [...] > >> When to exit 0 on error? > > > > When the error is unrecoverable, and

[tor-dev] When to exit 0 on error

2017-06-23 Thread f55jwk4f
I noticed tor sometimes exits 0 on error, specifically in monitor_owning_controller_process in src/or/control.c: if (owning_controller_process_monitor == NULL) { log_err(LD_BUG, "Couldn't create process-termination monitor for " "owning controller: %s. Exiting.", msg