Re: [tor-dev] Should cloud-hosted relays be rejected?

2015-09-02 Thread Michael McConville
tordev...@safe-mail.net wrote: > > > I'm not talking about those providers hosting exit nodes. I'm > > > talking about general web sites and resources hosted by them and > > > the traffic that goes there. > > > > I'm confused. You're worried about people hosting clearnet websites > > with cloud hos

Re: [tor-dev] Should cloud-hosted relays be rejected?

2015-09-01 Thread Michael McConville
tordev...@safe-mail.net wrote: > > I don't think banning GCE, AWS and MS Azure is an efficient method > > to significantly increase the cost of attacks because it is trivial > > for an attacker to quickly spin up "a large number of disposable > > machines" at other ISPs as well. > > It has other b

Re: [tor-dev] Remove NULL checks for *_free() calls

2015-08-30 Thread Michael McConville
Mansour Moufid wrote: > Michael McConville wrote: > > free() is specified to be NULL-safe, and I don't know of any > > implementations that violate this. > > I think those NULL checks are meant to avoid double-free bugs. If you > assign NULL to a pointer after you f

[tor-dev] Remove NULL checks for *_free() calls

2015-08-30 Thread Michael McConville
free() is specified to be NULL-safe, and I don't know of any implementations that violate this. Tor's *_free() functions conform, although relaycache_free() prints a warning (which I remove in the below diff). I checked every *_free() function for NULL-safety before removing conditions for it. Thi