Re: [tor-dev] Torsocks tests

2014-01-26 Thread Luke Gallagher
Hi David, Just wanted to give you a heads up to let you know that I'm back looking at the tests for torsocks, as its has been a while since the last few commits for tests (things got a little busy towards the end of last year). I'm continuing on from where I left off which is getting some tests in

Re: [tor-dev] Torsocks tests

2013-09-12 Thread Luke Gallagher
Hi David, On 12/09/13 11:57 PM, David Goulet wrote: > Hi Luke! > > Luke Gallagher: >> Hi David, >> >> I would like to make sure I'm heading in the right direction with >> the tests and have a few questions which I've compiled below: >> >>

Re: [tor-dev] Torsocks tests

2013-09-11 Thread Luke Gallagher
Hi David, I would like to make sure I'm heading in the right direction with the tests and have a few questions which I've compiled below: First of all generally speaking: I've taken the approach: if a declaration is defined in the header file then I'll aim to write tests for it, if it makes sen

Re: [tor-dev] Torsocks tests

2013-09-05 Thread Luke Gallagher
On 6/09/13 9:52 AM, David Goulet wrote: > So yes, please if you like to contribute more tests, that would be > great! > Great, thanks David. I'll make a start then and be in touch if I have any more queries regarding the tests. regards, Luke ___ t

[tor-dev] Torsocks tests

2013-09-05 Thread Luke Gallagher
Hi, I would like to help with the unit tests for Torsocks, I was thinking of starting with utils and config-file tests, does this sound like a reasonable place to start? regards, Luke ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists

Re: [tor-dev] Torsocks 2.0.0-rc1 release

2013-08-27 Thread Luke Gallagher
Thanks David, I've got the upstream changes which fixes quite a few things, so thank you. I've made some minor changes to make gcc happy which I've sent through in a pull request [1] and perhaps you can offer some feedback to ensure best practices are followed if needed. Apart from that it's bui

Re: [tor-dev] Torsocks 2.0.0-rc1 release

2013-08-25 Thread Luke Gallagher
Hi David, Thanks for your effort on the new version of Torsocks. I've had a brief look at getting a working build on OSX (10.8.4), however I've run into a few problems, which I'm attempting to work through, but I'm not entirely sure how to fix all of them, I'll see how far I get. The syscalls ar