Re: [tor-dev] [PATCH] fix GCC 7 implicit fallthroug warnings

2017-05-28 Thread Andreas Stieger
Hello, On 05/28/2017 11:01 PM, Andreas Stieger wrote: > __attribute__ ((fallthrough)); It turns out that this may not be as portable as I thought. Instead, the attached patch adds magic comments recognized by default -Wimplicit-fallthrough=3 or break, as required. Andreas -- Andreas Stie

[tor-dev] [PATCH] fix GCC 7 implicit fallthroug warnings

2017-05-28 Thread Andreas Stieger
-tor_gzi.patch Please review, Andreas -- Andreas Stieger Project Manager Security SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) >From 089c07448260fb9df1aed6cafd36334d64f8dfe7 Mon Sep 17 00:00:00 2001 From: Andreas Stieger Date: Sun, 28 May 2017 21:50

Re: [tor-dev] [PATCH] Log malformed hostnames in socks5 request respecting SafeLogging

2015-08-25 Thread Andreas Stieger
Hello, On 08/25/2015 08:16 AM, teor wrote: > On 24 Aug 2015, at 09:12, Andreas Stieger <mailto:astie...@suse.com>> wrote: >> I found a warning-level message in socks5 code relating to malformed >> hostnames that did not respect the SafeLogging setting, breaking the &

[tor-dev] [PATCH] Log malformed hostnames in socks5 request respecting SafeLogging

2015-08-23 Thread Andreas Stieger
Hello, I found a warning-level message in socks5 code relating to malformed hostnames that did not respect the SafeLogging setting, breaking the rule of least surprise. Please review the attached simple patch. Andreas -- Andreas Stieger Project Manager Security SUSE Linux GmbH, GF: Felix