Re: [tor-dev] Remove NULL checks for *_free() calls

2015-08-30 Thread Michael McConville
Mansour Moufid wrote: > Michael McConville wrote: > > free() is specified to be NULL-safe, and I don't know of any > > implementations that violate this. > > I think those NULL checks are meant to avoid double-free bugs. If you > assign NULL to a pointer after you free it and check all pointers >

[tor-dev] Remove NULL checks for *_free() calls

2015-08-30 Thread Michael McConville
free() is specified to be NULL-safe, and I don't know of any implementations that violate this. Tor's *_free() functions conform, although relaycache_free() prints a warning (which I remove in the below diff). I checked every *_free() function for NULL-safety before removing conditions for it. Thi

Re: [tor-dev] Hash Visualizations to Protect Against Onion Phishing

2015-08-30 Thread n...@cock.li
I came across this thread from the weekly news post for this week, so please excuse me if I've missed some from just skimming through the posts. Having randomart/gravatars/poems/etc seems like a rather interesting topic, but seriously adding it to tor, there seems to be a few problems in my mind:

[tor-dev] Donncha's SoP Status Report 7 - Final

2015-08-30 Thread Donncha O'Cearbhaill
Hello all, This is my seventh, and final biweekly status report for my hidden service scaling / load-balancing SoP project. Since my last status report: * I have been revising my patch for #14846 with the aim of getting it merged before the 0.2.7 feature freeze. * I've been working with Ivan Ma