Re: [tor-dev] Stem code review 2013-01-03

2013-01-05 Thread Damian Johnson
Hi Sean. As always, thanks for the code review! > I did find the 'assert extended == "EXTENDED"' test after is_ok() to be > strange... Oops, thanks for catching that. I don't mind a bit of paranoia in making sure that the response is giving us a circuit id but I've avoided using the assert keywo

[tor-dev] Stem code review 2013-01-03

2013-01-05 Thread Sean Robinson
Stem devs, This is a review of commits made to Stem from 2012-12-22 through 2013-01-03. Happy new year. I'm a fan of the new Controller.get_circuits() method. It's a nice and clever re-use of internal code. And it makes circuit-oriented method tests much more readable. Controller.get_circuit(

Re: [tor-dev] RFC on obfs3 pluggable transport

2013-01-05 Thread George Kadianakis
Hi all, I implemented a prototype obfs3 implementation that uses the UniformDH trick. It can be found in the `obfs3_take2` branch of https://git.torproject.org/user/asn/pyobfsproxy.git . gitweb link: https://gitweb.torproject.org/user/asn/pyobfsproxy.git/shortlog/refs/heads/obfs3_take2 Here is t