On Thu, Dec 20, 2012 at 11:25 AM, Nick Mathewson wrote:
> On Wed, Dec 19, 2012 at 8:57 PM, Simon wrote:
>> On Wed, Dec 19, 2012 at 4:35 PM, Nick Mathewson wrote:
>>> What's your favorite C mocking solution for integrating with existing
>>> codebases without much disruption?
>>
>> This could be w
> Yes :-) I've seen projects which have tests which take nearly 10 hours
> to run. However, the longer the tests take to run then the less likely
> that developers will run them.
Agreed. I run stem's unit tests more often than the integ tests since
those have the runtime of around five seconds. Fo
On Thu, Dec 20, 2012 at 2:43 PM, Damian Johnson wrote:
>>> You want to point at your tor binary, I think, not just the path
>>> (i.e. something like "--tor ../tor-2.3.*/src/or/tor")
>>
>> That did the trick, thanks:
>
> Oops, I'm sorry about not being clearer about that.
No problem.
>> Why do th
Hi Sean, thanks for the code review!
> Would GETINFO/GETCONF cache hit logging[1] benefit from log_once? Or even
> something between log and log_once (e.g. rate_limited_log)?
Interesting thought, but I don't think so. When I look for cache hits
it's usually to answer the question of 'did doing
Stem devs,
This is a review of Stem commits from 2012-12-11 through 2012-12-21.
Damian, you are very good at documentation, concise and informative. I
tend to hit one or the other, but not both. I recognize when someone gets
the right mix. Good work.
I, too, have found logging.basicConfig[0]
