Re: [tor-dev] [patch] fix cparser/firm compiler warnings

2012-10-14 Thread Nick Mathewson
On Sun, Oct 14, 2012 at 5:03 AM, Christian Grothoff wrote: > Hi! > > We're trying to compile Tor with cparser and got some warnings and an > error. Patch looks okay to me! In the future, it is indeed best to use the bugtracker. I've added it at https://trac.torproject.org/projects/tor/ticket/71

Re: [tor-dev] [patch] fix cparser/firm compiler warnings

2012-10-14 Thread Robert Ransom
On 10/14/12, Christian Grothoff wrote: > Is there a better place for sending patches that do not really require > broad discussion? Post them in the bug tracker (https://trac.torproject.org/), preferably as the URL and branch name of a Git branch or as a patch in ‘git format-patch’ format. Rob

[tor-dev] [patch] fix cparser/firm compiler warnings

2012-10-14 Thread Christian Grothoff
Hi! We're trying to compile Tor with cparser and got some warnings and an error. src/or/dirserv.c:803:1: error: declaration 'was_router_added_t dirserv_add_extrainfo(extrainfo_t*, const char**)' is incompatible with 'int dirserv_add_extrainfo(extrainfo_t*, const char**)' (declared at line 96:12)