Re: [tor-dev] Tor Export

2012-07-12 Thread Damian Johnson
> Maybe you could comment on the comments, or at least keep an eye on it Replied. I clicked watch but I'm not familiar with how github code reviews work so I might not notice updates. > Also, I don't suppose you know how to comment on the file, instead of on the > diff? I don't. Personally I do

Re: [tor-dev] Tor Export

2012-07-12 Thread Norman Danner
On 7/12/12 12:15 PM, Damian Johnson wrote: Also, you aren't checking that all of the descriptors are of the same type. If you get a list with both server descriptors and extrainfo descriptors then I'm not sure what this function will do, but it's probably not what the user wants. Please include

Re: [tor-dev] Encrypted PM site/hidden service

2012-07-12 Thread krugar
take a look at https://anonbox.net/ for a similar service. a few considerations: if you create an "app" that lives on a mobile phone, are private keys stored on the phone? are they secured somehow while the app is running / not running? which public keys will be stored on the phone? will messages

[tor-dev] New Identity/Client attacks?

2012-07-12 Thread Daniel Dennis
I'm doing a little brainstorming to properly secure my app specifically made for tor. I notice vidalia has a new identity button. I pressed it and couldn't tell what it did. While looking at the network view i saw a few connections get closed (but not all) and that was about it. It appears every

Re: [tor-dev] Tor Export

2012-07-12 Thread Damian Johnson
Hi Erik. In addition to Norman's feedback... > def descriptor_csv_exp(descr, head=True, incl_fields=[], excl_fields=[]): It's redundant to call this descriptor_csv_exp() since it's in 'stem.descriptor.*'. Lets just call it something simple like export_csv(). Also, I still think that we should com

[tor-dev] First five Tor tech reports

2012-07-12 Thread Karsten Loesing
Hi Roger, hi Nick, here are the first five metrics tech reports that I'd like to turn into Tor tech reports (see #5405 for the idea behind this). If you agree that this is a good idea, I'll push the sources to tech-reports.git and put the PDFs on the Tor website. I need your confirmation for eac