Re: xterm bug

2011-08-18 Thread Matthieu Herrb
On Thu, Aug 18, 2011 at 09:37:33AM -0500, Marco Peereboom wrote: > On Wed, Aug 17, 2011 at 04:11:55PM -0500, Marco Peereboom wrote: > > After the long debate yesterday about clipboards sucking major eggs and > > stuff I started looking into the problem. Where was that discussion? I seem to have m

Re: xterm bug

2011-08-18 Thread Marco Peereboom
On Wed, Aug 17, 2011 at 04:11:55PM -0500, Marco Peereboom wrote: > After the long debate yesterday about clipboards sucking major eggs and > stuff I started looking into the problem. One of the problems is that > xterm doesn't honor the "Keep Selection" flag. The code is a little > tangly but if

Re: xterm bug

2011-08-18 Thread Marco Peereboom
On Thu, Aug 18, 2011 at 02:45:37PM +0200, Pascal Stumpf wrote: > On Thu, Aug 18, 2011 at 06:46:12AM -0500, Marco Peereboom wrote: > > It doesn't because this isn't what the man page states for keep > > selection. It only works with Scrn* functions and does not get tested > > when DisownSelection i

Re: xterm bug

2011-08-18 Thread Marco Peereboom
On Thu, Aug 18, 2011 at 11:21:28AM +0200, Pascal Stumpf wrote: > On Thu, Aug 18, 2011 at 10:17:31AM +0200, Mark Kettenis wrote: > > Makes no sense. The keepSelection check is already done in > > ScrnDisownSelection(). The only place where DisownSelection() is > > called directly is SelectSet(), a

Re: xterm bug

2011-08-18 Thread Mark Kettenis
> Date: Thu, 18 Aug 2011 06:46:12 -0500 > From: Marco Peereboom > > > Hope this helps. > > It doesn't because this isn't what the man page states for keep > selection. It only works with Scrn* functions and does not get tested > when DisownSelection is called, which is called from some other sp

Re: xterm bug

2011-08-18 Thread Marco Peereboom
On Thu, Aug 18, 2011 at 10:17:31AM +0200, Mark Kettenis wrote: > > Date: Wed, 17 Aug 2011 16:11:55 -0500 > > From: Marco Peereboom > > > > After the long debate yesterday about clipboards sucking major eggs and > > stuff I started looking into the problem. One of the problems is that > > xterm d

Re: xterm bug

2011-08-18 Thread Pascal Stumpf
On Thu, Aug 18, 2011 at 10:17:31AM +0200, Mark Kettenis wrote: > Makes no sense. The keepSelection check is already done in > ScrnDisownSelection(). The only place where DisownSelection() is > called directly is SelectSet(), and that should only happen if you > explicitly shrink your selection to

Re: xterm bug

2011-08-18 Thread Mark Kettenis
> Date: Wed, 17 Aug 2011 16:11:55 -0500 > From: Marco Peereboom > > After the long debate yesterday about clipboards sucking major eggs and > stuff I started looking into the problem. One of the problems is that > xterm doesn't honor the "Keep Selection" flag. The code is a little > tangly but

xterm bug

2011-08-17 Thread Marco Peereboom
After the long debate yesterday about clipboards sucking major eggs and stuff I started looking into the problem. One of the problems is that xterm doesn't honor the "Keep Selection" flag. The code is a little tangly but if I read it correctly it looks like a simple test was missed. This brings