Re: wcwidth() fixes in libcurses

2011-04-04 Thread Stefan Sperling
On Sun, Apr 03, 2011 at 11:21:35PM +0100, Nicholas Marriott wrote: > > - if (x + len - 1 <= win->_maxx) { > > + if (len >= 0 && x + len - 1 <= win->_maxx) { > > Not sure this is required, astr is a cchar_t * which will come from > setcchar. Right. That already makes sure the string cannot co

Re: wcwidth() fixes in libcurses

2011-04-03 Thread Nicholas Marriott
Hi On Sun, Apr 03, 2011 at 11:34:54PM +0200, Stefan Sperling wrote: > The upcoming diff to make wcwidth() return -1 for non-printable > characters might have funny effects for these callers in libcurses. > > Index: base/lib_addstr.c > ==

wcwidth() fixes in libcurses

2011-04-03 Thread Stefan Sperling
The upcoming diff to make wcwidth() return -1 for non-printable characters might have funny effects for these callers in libcurses. Index: base/lib_addstr.c === RCS file: /cvs/src/lib/libcurses/base/lib_addstr.c,v retrieving revision